eamon0989 commented 1 year ago

Description

set-output is being deprecated in GitHub actions, this PR replaces set-output with the recommendation from here. I tested the output using the following command to verify the result was the same:

      - name: Print prior output
        run: echo "${{ steps.extract-branch.outputs.branch }}"

And it printed "refs/pull/179/merge".

I also updated nrwl/nx-set-shas@v2 to v3 as v2 still used set-output and as a result, we received the warnings after the workflow ran. Warnings shown in the following screenshot:

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6dda93cd19e91638ecb8eefd95dbdc8ef514cb58. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 4 targets

- [`nx affected --target=test:cov`](https://cloud.nx.app/runs/xfaDFrqFr2) - [`nx affected --target=test:browser`](https://cloud.nx.app/runs/gxbi7vYZGO) - [`nx affected --target=build`](https://cloud.nx.app/runs/T5A18celpH) - [`nx run-many --target=lint --all`](https://cloud.nx.app/runs/lJBSMRKDUk)

Sent with 💌 from NxCloud.