Closed eamon0989 closed 1 year ago
CI is running for commit 690b0df48323d6a60e7d3351a3fcf9e580a147ab.
📂 Click to track the progress, see the status, the terminal output, and the build insights.
Sent with 💌 from NxCloud.
SonarCloud Quality Gate failed.
Description
handlebars
is a dependency of@s1seven/schema-tools-utils
, but it was not listed as a dependency. As@s1seven/schema-tools-utils
is a dependency of@s1seven/schema-tools-generate-pdf
, when trying to generate a PDF using Node-Red, it threwError: Cannot find module 'handlebars'
.It appears that Lerna handled the dependency when using
schema-tools
locally, but whengenerate-pdf
is used in a project where handlebars is not already present, it breaks.Instead of adding
handlebars
as a dependency, this PR moves the functiongetPartials
fromutils
togenerate-html
.Updates all the URLS in
fixtures
to useschemas.s1seven.dev
instead ofschemas.s1seven.com
.Adds a handlebars alias to the webpack config in
karma.conf.js
to remove webpack errors based on the issue found here: https://github.com/handlebars-lang/handlebars.js/issues/953Fixes s1seven/node-red-monorepo#4
Type of change
Checklist: