s1seven / schema-tools

Tools to create, validate and render certificates using Material Identity JSON schemas

https://materialidentity.org/

Apache License 2.0

1 stars 1 forks source link

Ci: danger step should NOT run on main (push or merge) #213

Closed getlarge closed 1 year ago

getlarge commented 1 year ago

Description

The latest workflow just failed during merge because danger is now run during merge as well. See : https://github.com/s1seven/schema-tools/actions/runs/4879728469/jobs/8706599658

@eamon0989 can you please add the condition that was probably already here before merging #208 ?

eamon0989 commented 1 year ago

I found the problem, the Extract branch name step was accidentally removed from the ci which caused Danger to run even when merging to main. I've restored it in https://github.com/s1seven/schema-tools/pull/212