eamon0989 commented 1 year ago

Description

We have been facing issues from having a mix of Lerna and Nx, this PR replaces Lerna completely with Nx. Removes mjml logic and html to pdf. Removes unneeded extends section from nx.json. We previously used parcel to generate the generateContent.js files, but it doesn't have a plugin that works with NX, so we switched to @nx/esbuild. esbuild by default emits esm files, which are not compatible with jest, so I've set the output to be a commonjs file. The code has been updated to expect a .cjs file. We previously had a second "browser" build for 2 packages, this has been removed and the karma tests have also been removed.

Fixes #210 Fixes #209 Fixes #202

Type of change

[x] Refactor (a code change that neither fixes a bug nor adds a feature)
[x] Dependencies update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8c790e3eb3334af4865534538efdc59167d81da4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 3 targets

- [`nx affected --target=build`](https://cloud.nx.app/runs/ZwdGygRcMn) - [`nx run-many --target=lint --all`](https://cloud.nx.app/runs/YzmAXhRNvg) - [`nx affected --target=test`](https://cloud.nx.app/runs/7jjSuBXL1T)

Sent with 💌 from NxCloud.

github-actions[bot] commented 1 year ago

	Warnings
:warning:	:exclamation: Big PR (1)

	Messages
:book:	:thumbsup: You removed more code than added!
:book:	:thumbsup: You ticked most of the checkboxes!

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, please split each into separate PRs which will make them easier to review.

Generated by :no_entry_sign: dangerJS against d237225d8d200772d7b2b226c19f43ec682361e4