s1seven / schema-tools

Tools to create, validate and render certificates using Material Identity JSON schemas
https://materialidentity.org/
Apache License 2.0
1 stars 1 forks source link

feat: name embedded json according the general convention #250

Open stiebitzhofer opened 7 months ago

stiebitzhofer commented 7 months ago

Description

What keywords did you search in schema-tools issues before filing this one ?

Is this a BUG REPORT or FEATURE REQUEST ? FEATURE

Environment: https://app.s1seven.co

What you expected to happen: Currently, the name of the JSON embedded is certificate.json. It should be named according to the general convention <SellerName>-<Certificate Number>.pdf.

The functions of @s1seven/certificate-summary shall be used.

christophbuehler commented 7 months ago

@stiebitzhofer Certificate Number = certificateIdentifier?

Which option to you like best?

Seller name: Green Plastics AG Certificate Identifier: 43


a) Green Plastics AG-43.pdf ← as specified b) green-plastics-ag-43.pdf ← replace spaces with - and lowercase c) green_plastics_ag-43.pdf ← replace spaces with _ and lowercase


To be honest, I like something generic like "certificate.pdf" better than any of those:

Maybe some combination with a prefix like certificate-?

stiebitzhofer commented 7 months ago

In the emails, we name it "GreenPlasticsAG-CN-43.json". CN for Certificate Number. I never like it if file names for downloads are always the same. Okay?