search

s32x / anirip

:clapper: A Crunchyroll show/season ripper
MIT License
158 stars 37 forks source link

Better errors, fixed subtitle issue, and minor changes #45

Closed turtletowerz closed 5 years ago

turtletowerz commented 5 years ago

This PR looks like it changed quite a lot but in reality there were only two major changes

First, I removed the /common/error.go file and replaced it with the newer wrapped errors. This will make it easier to figure out specific errors in the future due to it being an amateur stack trace

Second, I rewrote a small part of the /crunchyroll/subtitle.go file to use regular expressions to find video metadata. The older method was less efficient and this one seems to work in all tests I've done. It also (should) fix #43

I also made minor changes, such as re-adding the /.circleci/ folder to fix the failed build error it shows on the README. Lastly, I made it so the subtitles will not be forced to English, the user's preference should work now

s32x commented 5 years ago

Hey sorry, it took me so long to take a look at this. I've been traveling a lot the past few weeks and just noticed it in my Github notifications. Everything looks great! I love that you're using the new error wrapping. Thanks so much for the help with this! :)

turtletowerz commented 5 years ago

You're welcome! I'll probably submit another PR soon that would allow for single episodes to be downloaded, but it might change a lot (I haven't quite worked out the most efficient way to do it yet).