search

s3rius / FastAPI-template

Feature rich robust FastAPI template.
MIT License
1.94k stars 171 forks source link

Readme typo #139

Closed haluk closed 1 year ago

haluk commented 1 year ago

there was a minor typo in the project template README.md.

s3rius commented 1 year ago

Wow. Much thanks for contribution!

s3rius commented 1 year ago

Did you update dependencies also?

haluk commented 1 year ago

For opentelemetry yes but in a separate branch.

s3rius commented 1 year ago

Would you mind if I only merge this branch and close another one?

haluk commented 1 year ago

Sure. Actually my bad. I was supposed to create separate branch for each items. This branch contains all my changes. Sorry for the confusion.

s3rius commented 1 year ago

No, it's totally fine, since it takes approx an hour to run full test suite.

Thank you.