search

s3rius / FastAPI-template

Feature rich robust FastAPI template.
MIT License
1.94k stars 171 forks source link

yesqa in pre-commit #140

Closed tschiolborg closed 1 year ago

tschiolborg commented 1 year ago

In the README it says the pre-commit runs yesqa. It is also being installed as an dependency in pyproject.toml.

However, it seems like yesqa was removed from the pre-commit in https://github.com/s3rius/FastAPI-template/pull/94.

It think we should either re-add yesqa in the pre-commit or remove it from dependencies and README.

s3rius commented 1 year ago

Hi. And thanks for raising this issue. I guess removing it would be totally ok, since it's easy to add it if you want to.

s3rius commented 1 year ago

You can create Pull request in develop branch. Or I can do it later.