search

s3rius / FastAPI-template

Feature rich robust FastAPI template.
MIT License
1.83k stars 161 forks source link

Update settings.py #145

Closed EduardoBortotti closed 1 year ago

EduardoBortotti commented 1 year ago

change from "localhost" to container name

sorasful commented 1 year ago

Hi there, I'm not sure this is a good idea, because it would means that we would not be able to start the project using poetry run python -m yourproject inside a shell on our host. You'd have to start your fastapi app using docker-compose and for local development it may not be the best case for the majority of people.

What do you think ?

s3rius commented 1 year ago

Hi! And thanks for creating this pull request. But I don't think that your changes are necessary, since it would break tests in the first place and if you really want to change it to localhost you can create a variable in .env file or override it in your generated project.

s3rius commented 1 year ago

Closed due to inactivity.