search

s3rius / FastAPI-template

Feature rich robust FastAPI template.
MIT License
1.94k stars 171 forks source link

Invalid integration of loguru #154

Closed fmigneault closed 1 year ago

fmigneault commented 1 year ago

Using a setup with loguru omitted from the selected components, it still finds its way here: https://github.com/s3rius/FastAPI-template/blob/master/fastapi_template/template/%7B%7Bcookiecutter.project_name%7D%7D/%7B%7Bcookiecutter.project_name%7D%7D/logging.py#L5

s3rius commented 1 year ago

Hi, and thanks for raising this issue. What do you mean? Like logging.py isn't removed from the project after the generating is done, even if loguru option is unchecked?

s3rius commented 1 year ago

Because the logging.py file appears only if you enabled the loguru feature. Otherwise it must be deleted.

fmigneault commented 1 year ago

I recreated a project to validate, and you're right, it was not included this time. I must have made a configuration mistake without realizing. Thanks!

s3rius commented 1 year ago

Thank you for finding it out. Guess I can close #124 as well.