search

s3rius / rustus

TUS protocol implementation in Rust.
https://s3rius.github.io/rustus/
MIT License
158 stars 13 forks source link

Read secrets from paths #132

Closed happysalada closed 1 year ago

happysalada commented 1 year ago

Hi, thanks for the awesome software !

Would it be possible to have an option to read secrets from a path instead of directly from a value ?

The reason i ask this is that both docker secrets and systemd load credentials which are systems to manage secrets both want to read from a path rather than from a naked value.

So just adding an option to read a secret from a path would be great for security

s3rius commented 1 year ago

Hi and thanks for raising an issue. I'll take a look this week what can I do. Can you provide more information about how would you like this feature to be implemented?

happysalada commented 1 year ago

Thanks for coming by so quickly !

I dont know all the secrets that are handled by the app, but typically, for s3-secret-key The cli flag would be --s3-secret-key-path that would expect a file path and the application wouls read the content of the file and store that as the value it needs.

Environmenr variable would be the same.

Let me know if that doesnt make sense.

happysalada commented 1 year ago

Just to make sure I was clear. The idea would be to add 2 more variables RUSTUS_S3_ACCESS_KEY_PATH="/run/secrets/s3_access_key"; RUSTUS_S3_SECRET_KEY_PATH="/run/secrets/s3_secret_key"; and the application to read the content of the two files and to get the variables from there.

happysalada commented 1 year ago

Thank you for your help merging this!

s3rius commented 1 year ago

Thanks for your request in the first-place.