Switch to stable + Fix CORS

s3rius / rustus

TUS protocol implementation in Rust.

https://s3rius.github.io/rustus/

MIT License

158 stars 13 forks source link

Switch to stable + Fix CORS #149

Closed reneklacan closed 6 months ago

reneklacan commented 6 months ago

Switch to stable Rust
- The only thing that needed nightly was rustfmt's imports_granularity which I believe is small price to pay for switching to stable
Fix CORS preflight requests (info on options conflicted with CORS layer preflight logic and was breaking web JS client) by moving info headers to included in all requests

s3rius commented 6 months ago

Thanks you very much. If you tried to fix rustus that is published on docker hub, then it won't work, because version on master branch is different to what is published on hub.

I will try to update the project and will publish it on hub this or next week.

reneklacan commented 6 months ago

@s3rius version in dockerhub actually worked ok but then when I switched to building image from latest code (develop branch), I ran into CORS issues and these changes fixed them

reneklacan commented 6 months ago

@s3rius do you want me to fix failing lint or do you just plan to address this in a different way? I'm fine either way!

s3rius commented 6 months ago

I'd love if you will fix it.

reneklacan commented 6 months ago

@s3rius cool, pushed fixes

s3rius commented 6 months ago

Seems good to me.