s3team / Squirrel

MIT License
184 stars 54 forks source link

Please add -Wno-dev to build command #22

Closed mariadb-RoelVandePaar closed 1 year ago

mariadb-RoelVandePaar commented 1 year ago
cmake -S . -B build -DCMAKE_BUILD_TYPE=Release -Wno-dev

Avoids a large number of warnings on Ubuntu 20.04.5 LTS. Warnings seen:


-- Found Threads: TRUE  
CMake Warning at third_party/abseil-cpp/CMakeLists.txt:72 (message):
  A future Abseil release will default ABSL_PROPAGATE_CXX_STD to ON for CMake
  3.8 and up.  We recommend enabling this option to ensure your project still
  builds correctly.

CMake Warning (dev) at third_party/abseil-cpp/CMake/AbseilDll.cmake:407:
  Syntax Warning in cmake code at column 19

  Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
  third_party/abseil-cpp/CMakeLists.txt:86 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at third_party/abseil-cpp/CMake/AbseilDll.cmake:408:
  Syntax Warning in cmake code at column 17

  Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
  third_party/abseil-cpp/CMakeLists.txt:86 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at third_party/abseil-cpp/CMake/AbseilDll.cmake:409:
  Syntax Warning in cmake code at column 11

  Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
  third_party/abseil-cpp/CMakeLists.txt:86 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at third_party/abseil-cpp/CMake/AbseilDll.cmake:442:
  Syntax Warning in cmake code at column 32

  Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
  third_party/abseil-cpp/CMakeLists.txt:86 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at third_party/abseil-cpp/CMake/AbseilDll.cmake:443:
  Syntax Warning in cmake code at column 24

  Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
  third_party/abseil-cpp/CMakeLists.txt:86 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Performing Test ABSL_INTERNAL_AT_LEAST_CXX17
-- Performing Test ABSL_INTERNAL_AT_LEAST_CXX17 - Failed
CMake Warning (dev) at third_party/abseil-cpp/CMake/AbseilDll.cmake:407:
  Syntax Warning in cmake code at column 19

  Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
  third_party/abseil-cpp/CMake/AbseilHelpers.cmake:19 (include)
  third_party/abseil-cpp/CMakeLists.txt:87 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at third_party/abseil-cpp/CMake/AbseilDll.cmake:408:
  Syntax Warning in cmake code at column 17

  Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
  third_party/abseil-cpp/CMake/AbseilHelpers.cmake:19 (include)
  third_party/abseil-cpp/CMakeLists.txt:87 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at third_party/abseil-cpp/CMake/AbseilDll.cmake:409:
  Syntax Warning in cmake code at column 11

  Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
  third_party/abseil-cpp/CMake/AbseilHelpers.cmake:19 (include)
  third_party/abseil-cpp/CMakeLists.txt:87 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at third_party/abseil-cpp/CMake/AbseilDll.cmake:442:
  Syntax Warning in cmake code at column 32

  Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
  third_party/abseil-cpp/CMake/AbseilHelpers.cmake:19 (include)
  third_party/abseil-cpp/CMakeLists.txt:87 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at third_party/abseil-cpp/CMake/AbseilDll.cmake:443:
  Syntax Warning in cmake code at column 24

  Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
  third_party/abseil-cpp/CMake/AbseilHelpers.cmake:19 (include)
  third_party/abseil-cpp/CMakeLists.txt:87 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

Also, even after adding this option we still see:

CMake Warning at third_party/abseil-cpp/CMakeLists.txt:72 (message):
  A future Abseil release will default ABSL_PROPAGATE_CXX_STD to ON for CMake
  3.8 and up.  We recommend enabling this option to ensure your project still
  builds correctly.

So it would be good to fix this also. cmake version is 3.16.3