s3team / Squirrel

MIT License
184 stars 54 forks source link

Possible improvement for custom mutator #25

Closed mariadb-RoelVandePaar closed 1 year ago

mariadb-RoelVandePaar commented 1 year ago

Impressive work so far guys :) Have not got it running yet, but close

Possible improvement opportunity for the new custom mutator:

[*] Custom mutator does not implement all three trim APIs, standard trimming will be used.

Some other potential opportunities:

[*] optional symbol 'afl_custom_init_trim' not found.
[*] optional symbol 'afl_custom_trim' not found.
[*] optional symbol 'afl_custom_post_trim' not found.
[*] optional symbol 'afl_custom_havoc_mutation' not found.
[*] optional symbol 'afl_custom_havoc_mutation_probability' not found.

Seen during afl-fuzz startup

Changochen commented 1 year ago

These symbols are optional and will not affect anything.

mariadb-RoelVandePaar commented 1 year ago

I know they are optional. But are you sure that implementing them will have no effect?