s41r4j / phomber

[PH0MBER]: An open source infomation grathering & reconnaissance framework!
https://pypi.org/project/phomber/
GNU General Public License v3.0
364 stars 52 forks source link

Code Review #2

Closed TotallyNotAHaxxer closed 2 years ago

TotallyNotAHaxxer commented 2 years ago

I like the tool, over all you have GREAT code, great functionality, and even organizations, I also see everything under a definition and call it with if name in main, like seeing it

however one thing I noticed is you have ‘’’python

import phonenumbers, sys, datetime, progressbar, time, mechanize, os

‘’’

this is a good strategy however it can slow down the scripts runtime, a better opposition would be

‘’’python Import sys Import os Import date time Etc ‘’’

just something to make the runtime a bit better, but everything else looks fine, nice job!

s41r4j commented 2 years ago

@ArkAngeL43 , Hey !

Thanks for reviewing code ! I'll surely see to it .

(Blooper alert) I'm right trying to improve code structure and bring you all direct - CLI - program

TotallyNotAHaxxer commented 2 years ago

ofc! if you neeed help with the project let me know and we can chat over discord or something to plan ways to make it a better script

s41r4j commented 2 years ago

@ArkAngeL43 - OR anyone, who want to contribute to any project - I'm Building a discord server - soon will be available on profile (special repo) . Hey till we can discuss on Instagram !! Please DM me (anyone who is interested) on my Instagram @s41r4j

benja902 commented 2 years ago

hello friend thanks for all the support I wanted to tell you my problem

since in the last step to locate the phone I get this

Traceback (most recent call last): File "/home/kali/Desktop/phomber/phomber.py", line 21, in import phonenumbers, sys, datetime, progressbar, time, mechanize, os ModuleNotFoundError: No module named 'progressbar'

I don't know if you could help me, thanks

s41r4j commented 2 years ago

@benja902 The error says everything! You don't have a module (ModuleNotFoundError last line) installed needed for the program to run, named progressbar. Therefore in python you can install an module with pip you just need to type command in cmd (for windows) or terminal (for linux/unix) [same command for both] : pip install progressbar

benja902 commented 2 years ago

@s41r4j I already did it but I get the same error image

TotallyNotAHaxxer commented 2 years ago

did you do pip3? sometimes that works

benja902 commented 2 years ago

@s41r4j I was able to do it thanks for the instructions