s4hts / HTStream

A high throughput sequence read toolset using a streaming approach facilitated by Linux pipes
https://s4hts.github.io/HTStream/
Apache License 2.0
49 stars 9 forks source link

auto generating version.h #188

Closed joe-angell closed 4 years ago

joe-angell commented 4 years ago

NOTE: must delete CMakeCache.txt from root src directory or this will not work

generates version.h based on git tag, and will always be up to date when you run make.

msettles commented 4 years ago

looks great and work on my computer, Only Q is on a release, the binaries will have the correct version number because they will be compiled by one of us (@samhunter ) but the source tar.gz? will that be able to get and attached the version if it isn't a git repo?

joe-angell commented 4 years ago

looks great and work on my computer, Only Q is on a release, the binaries will have the correct version number because they will be compiled by one of us (@samhunter ) but the source tar.gz? will that be able to get and attached the version if it isn't a git repo?

Yeah sam and I were discussing that issue, and I don't have a good solution right now. It seems github doesn't make it easy to change the release, but I'll look around a bit more.

joe-angell commented 4 years ago

So I created a file version.h.release that should be updated when we do a release, that file will be used for the version number if there is no access to github.