s5bug / discord-intellij

A plugin for interaction between JetBrains IDEs and Discord RPC
http://plugins.jetbrains.com/plugin/10217-intellij-discord-integration
24 stars 4 forks source link

PyCharm Edu has its own icon, but it's stuffed with Community and Professional in the code #10

Closed Jonathing closed 6 years ago

Jonathing commented 6 years ago

PyCharm Community and PyCharm Professional have the same icon, PC, with PyCharm Edu having the icon PE. https://i.imgur.com/aNxN0ky.png

In the code, they are stuffed into PyCharm together. https://i.imgur.com/GaOW3SY.png

Since I haven't tested v1.4.1 (since JetBrains hasn't verified the update into the plugin repo yet, and I cannot build it itself in IntelliJ IDEA for some reason), I'm not sure if the code "pe" would be disregarded, and the small icon in the Rich Presence interface would have the PC icon instead. Would that be the case?

s5bug commented 6 years ago

getIDEName doesn't control the icon, but if you can find the PyCharm Edu logo in the branding lists, I'll be happy to add it to the Rich Presence.

On Sun, Dec 10, 2017 at 1:04 PM Jonathan Colmenares < notifications@github.com> wrote:

PyCharm Community and PyCharm Professional have the same icon, PC, with PyCharm Edu having the icon PE. [image: https://i.imgur.com/aNxN0ky.png] https://camo.githubusercontent.com/bc7e2dc69eefddb3c072540e0fecc4697fe573c1/68747470733a2f2f692e696d6775722e636f6d2f614e784e306b792e706e67

In the code, they are stuffed into PyCharm together. [image: https://i.imgur.com/GaOW3SY.png] https://camo.githubusercontent.com/52f97d42c9da5658cf42605b326d6c40881921ce/68747470733a2f2f692e696d6775722e636f6d2f47614f573353592e706e67

Since I haven't tested v1.4.1 (since JetBrains hasn't verified the update into the plugin repo yet, and I cannot build it itself in IntelliJ IDEA for some reason), I'm not sure if the code "pe" would be disregarded, and the small icon in the Rich Presence interface would have the PC icon instead. Would that be the case?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/TsundereBug/discord-intellij/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/AHZGgKelNJjkeT_kOQsemvH-EpQr6WI6ks5s_EdVgaJpZM4Q8pl_ .

-- Fightin' Bad Guys ̿ ̿ ̿'̿'\̵͇̿̿\з=(•_•)=;5/̵͇̿̿/'̿'̿ ̿ Anthony

Jonathing commented 6 years ago

@TsundereBug Here's a link to all the logos you can find for each of the IDEs. They're near the bottom of the page just below the JetBrains icons downloads. https://www.jetbrains.com/company/press/

s5bug commented 6 years ago

See #11