s60sc / ESP32-CAM_MJPEG2SD

ESP32 Camera motion capture application to record JPEGs to SD card as AVI files and stream to browser as MJPEG. If a microphone is installed then a WAV file is also created. Files can be uploaded via FTP or downloaded to browser.

GNU Affero General Public License v3.0

888 stars 209 forks source link

re: CAMERA_MODEL_NEW_ESPS3_RE1_0 SD_MMC pins #418

Closed OldYin closed 5 months ago

OldYin commented 5 months ago

I know you intended to get these right but a minor typo makes them wrong. I know that anybody who actually owns one of these boards, won't be confused... for long but I figured you would like to correct this.

In camera_pins.h You have:

//Define SD Pins

define SD_MMC_CLK 42

define SD_MMC_CMD 39

define SD_MMC_D0 4

Correct pins are:

//Define SD Pins

define SD_MMC_CLK 42

define SD_MMC_CMD 39

define SD_MMC_D0 41

Regards, Alex

s60sc commented 5 months ago

Thanks. I dont have this board myself so see if @rjsachse will confirm as they provided the update

rjsachse commented 5 months ago

Good morning, I don't have that board either. I just copied the pins from appGlobals.h and pasted in camera_pins.h I noticed the board got added in march in version 9.62. Surprisingly you are the first to noticed. Easy fix.

rjsachse commented 5 months ago

Pull Request done

OldYin commented 5 months ago

If I may refer you to issue #379 in which mamazad7 posted full pin details (with diagrams) for this board. Hope that helps. Also I DO have this board :)

regards, Alex

rjsachse commented 5 months ago

Been fixed just waiting on @s60sc to accept pull request, it was a typo in version 9.62.

OldYin commented 5 months ago

No worries; thanks :)