s60sc / ESP32-CAM_MJPEG2SD

ESP32 Camera motion capture application to record JPEGs to SD card as AVI files and stream to browser as MJPEG. If a microphone is installed then a WAV file is also created. Files can be uploaded via FTP or downloaded to browser.
GNU Affero General Public License v3.0
888 stars 209 forks source link

CAMERA_MODEL_ESP32S3_EYE_FREENOVE In camera_pins.h But Not Elsewhere #469

Closed mrmonteith closed 1 month ago

mrmonteith commented 1 month ago

This might be a cleanup issue. But found out that CAMERA_MODEL_ESP32S3_EYE_FREENOVE is in the camera_pins.h, but not in the appGlobals.h

rjsachse commented 1 month ago

either CAMERA_MODEL_ESP32S3_EYE or CAMERA_MODEL_FREENOVE_ESP32S3_CAM will select CAMERA_MODEL_ESP32S3_EYE_FREENOVE this is not a issue

mrmonteith commented 1 month ago

But, if it's in there shouldn't it be i the appGlobals.h? Is there a need for CAMERA_MODEL_ESP32S3_EYE_FREENOVE to be in there?

rjsachse commented 1 month ago

There is 2 boards under CAMERA_MODEL_ESP32S3_EYE_FREENOVE that is a just a define for log. It is ment to be like.