s8sg / goflow

A Golang based high performance, scalable and distributed workflow framework
MIT License
1.16k stars 144 forks source link

[GOFLOW-31] Unit testing and coverage are missing #31

Open giorgiozoppi opened 1 year ago

giorgiozoppi commented 1 year ago

Goflow: Unit testing and coverage

Goal

Provide a 95% unit test mocking where it's opportune with gomock. No tests are present in the current code base.

s8sg commented 1 year ago

@giorgiozoppi This is where I need help. I didn't had enough bandwidth to look at the project recently. What I'm thinking is s simplify a lot of implementation and add test

Do you have any idea how we can start ?

giorgiozoppi commented 1 year ago

I would start from the lower level possibile. Is that the datastore? I also use this way of doing tickets for matching branches.

s8sg commented 1 year ago

We need to test this first https://github.com/s8sg/goflow/tree/master/core/sdk

This has all core functionalities

giorgiozoppi commented 1 year ago

Ok, i branch out, please use the same schema to rename different issues. The name of teh banch will be feature/goflow-31-unit-testing.

s8sg commented 1 year ago

Lets use - issue-31

On Sat, 11 Mar 2023 at 23:01, Giorgio Zoppi @.***> wrote:

Ok, i branch out, please use the same schema to rename different issues. The name of teh banch will be feature/goflow-31-unit-testing.

— Reply to this email directly, view it on GitHub https://github.com/s8sg/goflow/issues/31#issuecomment-1464942074, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYIJ2REFCFQQQTV2TPKO73W3SOUJANCNFSM6AAAAAASGAASJE . You are receiving this because you commented.Message ID: @.***>

giorgiozoppi commented 1 year ago

Branched out, i start working on this.