Closed dan2li closed 11 months ago
I think this will cause error at https://github.com/s8sg/goflow/blob/7d15cb086eca3560dfea70922c10af2b230e7c85/core/sdk/executor/executor.go#L1353C2-L1353C21
I think instead of performing cleanup we can directly return and let the above line take care. WDYT ?
Sure thing! I've added a commit and removed the cleanup operation. By the way, just wanted to mention that in my testing, I didn't encounter the error you mentioned above. 😉
@danl5 Interesting. Wonder why ?
Could it be that the pipeline was terminated prematurely because the stop operation, and did not follow the standard procedure of setting finished
to true?
If pipeline is not active, don't enqueue requests of the next nodes and forward the state.
Code Change: Before executing any other logic in
handleNextNodes
, check if the pipeline is active. If it is not, simply return.