s9e / phpbb-ext-highlighter

MIT License
15 stars 8 forks source link

loader.min.js and GDPR #7

Closed ste101 closed 4 years ago

ste101 commented 4 years ago

Because of the GDPR rules is would be better to include the loader.min.js into the EXT to load it localy.

JoshyPHP commented 4 years ago

I'd rather leave it to site owners to comply with all the applicable laws.

ste101 commented 4 years ago

That's ok but loader.min.js is loaded from another domain so your plugin is not GDPR complicant by default. Is there a special reason why you want to load loader.min.js from a CDN instead of loading it localy?

JoshyPHP commented 4 years ago

That's because the alternative is to bundle not just the loader but also the whole highlight.js library (which is currently loaded from the same CDN) and its nearly 200 files.