Clean up media library popup

s9y / Serendipity

A PHP blog software

https://s9y.org

BSD 3-Clause "New" or "Revised" License

207 stars 86 forks source link

Clean up media library popup #30

Closed yellowled closed 11 years ago

yellowled commented 11 years ago

In the media library popup/overlay window

[x] get rid of the internal frameset
[x] replace Yahoo treeview by jqTree (or our own solution)
[x] also open the media libary popup in overlay window if not using wysiwyg editor
~~adapt layout in media db overlay~~
~~adapt size of media db overlay~~

yellowled commented 11 years ago

@onli – could you take care of the popup thing? I don't get it.

Let's postpone the other two items (frameset/treeview) until after my vacation, I think this needs another conference call to line out how to approach this best …

yellowled commented 11 years ago

I just realized that jQuery treeview is no longer being actively maintained. jqTree is the proposed successor, but we might as well just roll our own solution based on the “Manage directories” code.

onli commented 11 years ago

ok, agreed. But before that, we wil lneed to decide how to display it. Simply in the same spot, but only visible when selecting media for a textarea? Or do we somehow try to make the folder-selection-filter more useful instead?

yellowled commented 11 years ago

Can we postpone this until after my vacation and discuss it in Mumble then? I would like to test the backend more extensively on small screens/touch devices first to get a feel for what's possible/reasonable in terms of layout there.

onli commented 11 years ago

Of course. I didn't expected an answer for you till after. But possible I will try some stuff till then.

yellowled commented 11 years ago

Note: If I figured this out correctly, the “wrong” layout of filter elements in media library overlays is actually correct – because the overlay includes and iframe and has a defined width. So @media queries apply to this iframe just as well, and since it's 900px wide, it does not get the “netbook” layout.

So what really would be the issue here is if our (pretty much standard) breakpoints are correct or if we should i.e. lower the “netbook” breakpoint from 1024px to e.g. 900px. Since that's a different issue and involves much testing, I'll open a seperate issue for it.

yellowled commented 11 years ago

This might need further discussion, especially about the tree view replacement, but I'm going to close it for the time being since it's done.