search

s9y / Serendipity

A PHP blog software
https://s9y.org
BSD 3-Clause "New" or "Revised" License
207 stars 86 forks source link

improve spartacus.s9y.org theme section #314

Closed garvinhicking closed 9 years ago

garvinhicking commented 9 years ago
garvinhicking commented 9 years ago

You can now see it like this:

http://blog.s9y.org/index.php?user_template=additional_themes/1024px http://blog.s9y.org/index.php?user_template=Serendipity

Before we really implement this to the spartacus view however we might want to make sure that every plugin actually works on blog.s9y.org. We'll need to create a blacklist for themes that will not work, so that they are not selectable on blog.s9y.org.

(The theme selection is saved in a 30-days cookie. We will still need to adapt the plugin so that on blog.s9y.org it can be configured to only save it in the browser session. Else, if one theme fails, the blog will always fail for users and they can't acccess our blog).

Anybody volunteer for checking the available themes in the site? @donchambers @ddeimeke ? :)

donchambers commented 9 years ago

Sure - isn't there a dropdown for theme selection?

Has the blog always been in German?

The only thing that really stands out as German to me is the continue reading link, and the entry footer...
yellowled commented 9 years ago

(By ✔ I mean: I have looked at the theme's index page in blog.s9y.org using the URL above.)

✔ chocolate_fudge ✔ GreenMile ✔ Modern_World_s9y_port ✔ Sagittarius-A (although it does not work too well since it's a magazine theme which requires some specific settings and markup)

Errors:

yellowled commented 9 years ago

Has the blog always been in German?

What makes you think the blog is in German?

bauigel commented 9 years ago

2015-03-10 14:57 GMT+01:00 Matthias Mees notifications@github.com:

Has the blog always been in German?

What makes you think the blog is in German?

​Maybe: "Serendipity Camp 2015 and the near future of Serendipity" vollständig lesen http://blog.s9y.org/archives/262-Serendipity-Camp-2015-and-the-near-future-of-Serendipity.html#extended ​ Or: Geschrieben von Garvin Hicking http://blog.s9y.org/authors/3-Garvin-Hicking in

donchambers commented 9 years ago

Yep

yellowled commented 9 years ago

RoundedCorner has a syntax error in index.tpl

Just pushed a fix for that. Hope that's all there's to it.

✔ adaptation ✔ andreas00 ✔ andreas06 ✔ andreas08 ✔ andreas09 (almost all the andreas themes do not use core nav, so they look a bit weird in the demo context because the nav items are empty) ✔ artistic ✔ axcur

Errors:

yellowled commented 9 years ago

Oh, okay. I did not notice that. I was testing themes and I usually only read the blog in RSS form. :) So no idea if the blog was not in German earlier.

yellowled commented 9 years ago

✔ bartleby ✔ bazooka ✔ be-nice (Did that always have a half-naked lady as a header img?! o_O) ✔ blogger_death ✔ blue-haze ✔ blue-iceberg (boy, that's an ugly one) ✔ brownpaper ✔ carl_blue ✔ carl_green ✔ ceejay01

Errors:

garvinhicking commented 9 years ago

Don't know when that happened; possibly I changed my local interface to german and then saved the global configuration of the blog, which set the language to german there. Sorry for that! Fixed!

About the themes: They all come from additional_themes/XXX/ so any plugin that references its assets not via getFile but via templates/myname/XXX will not work on blog.s9y.org...

donchambers commented 9 years ago

✔ zenlike ✔ youngbutstrong (no continue reading link) ✔ xkur ✔ xhtml_mp - this is the mobile plugin. Blacklist? ✔ wp-clone ✔ truth ✔ translucency ✔ toolbox

terrafirma fails to load "category.gif", which comes before the continue reading link

yellowled commented 9 years ago

✔ chromZv2 ✔ codeschmiede ✔ coffee_bar ✔ connections ✔ costa-nature_theme ✔ dreisechzig ✔ earphone ✔ elitist-latte ✔ fifty50

yellowled commented 9 years ago

✔ gila_two ✔ glossy_white ✔ hemingway ✔ hipporatorium – it does look broken, but I don't think it is … ✔ jazzcafe ✔ joshua ✔ joshua_nino ✔ joshua_tree

donchambers commented 9 years ago

✔ tabacco_s9y_07 ✔ styled-bar

Square - throwing an error for a missing language file. The theme does have a few configurable items, but they are all hard coded in English. This is a theme by Dave Cummins. He probably intended to create a language file, just never got around to it. I will create the english language file, and if anyone else wants to translate it, be my guest.

yellowled commented 9 years ago

He probably intended to create a language file, just never got around to it.

I think we may have added that $probelang check later. Not sure if it's safe to remove from config.inc.php, though.

ddeimeke commented 9 years ago

Sorry guys, you are much too fast for me.

donchambers commented 9 years ago

I think we may have added that $probelang check later. Not sure if it's safe to remove from config.inc.php, though.

I'm fixing it..... though I question my sanity for doing so!

yellowled commented 9 years ago

✔ kamouflage ✔ ladybird ✔ ladybug ✔ leaf ✔ mimbo (although it looks weird because obviously its options have not been customized) ✔ mo3 (same as mimbo, magazine tpl weirdness) ✔ morsel ✔ newfangled

yellowled commented 9 years ago

Sorry guys, you are much too fast for me.

No worries, Dirk. Need a break myself now. :)

I'm really wondering about these themes that only have a preview_fullsize.jpg, though. At least some of them have more files in the 2.0 branch of additional_plugins. Maybe @onli can shed some light on this since he seems to have worked in additional_plugins/2.0 last? This might be an incomplete merge or a merge that still needs to be done …?

donchambers commented 9 years ago

Square - throwing an error for a missing language file.

I created the missing English language file, and modified the config accordingly. @garvinhicking - you need to download the latest version.

donchambers commented 9 years ago

splat - blacklisted

donchambers commented 9 years ago

✔ softenedcells ✔ soccer2006 ✔ slate-grey ✔ simpla ✔ Sagittarius-A (newspaper style, looks slightly weird due to lack of configuration) ✔ safety-yellow ✔ s9y_thin ✔ s9y_orange (h1 & h2 links in banner are display:none. theme is mostly just a stylesheet) ✔ s9y_bluegrey

rubyx - same issue as square, missing language file, same config items as square so I'll add the english language file and modify config.

onli commented 9 years ago

Maybe @onli can shed some light on this since he seems to have worked in additional_plugins/2.0

additional_themes - but no, I'm not aware of anything. If files are missing that is not intended, though I think that 2.0 never uses the old preview anyway.

yellowled commented 9 years ago

If files are missing that is not intended, though I think that 2.0 never uses the old preview anyway.

Given the current state of the additional_themes repository, I would assume the following. It doesn't matter who commited it, by the way. :)

I guess the only actual question here – not necessarily directed at you ;) – is: is there a good reason for having some theme files only in additional_themes/2.0 or can we merge those to additional_themes/master now?

donchambers commented 9 years ago

✔ resy

Now on reflection, and once again it is missing a language file, which leads me to two questions.

1) I'm thinking I would rather remove the reference to a language file, than continue writing them. Anyone have a problem with that?

2) I keep finding config items specified as this:

    array(
        'var'           => 'navlink1text',
        'title'         => 'Navlink #1 Text',
        'description'   => 'Enter the first navigation text',
        'type'          => 'string',
        'default'       => 'About',
    ),

"title" doesn't seem to work. All my themes use "name", which does work. Did "title" work at some point in the past, and not now in 2.0? If it did before, but doesn't now, that functionality probably needs to be restored, or every theme that uses "title" has to be changed to "name". I have already modified the themes square and rubyx to use "name".

yellowled commented 9 years ago

I'm thinking I would rather remove the reference to a language file, than continue writing them.

That's what I meant above. Don't know if it's safe to remove.

Did "title" work at some point in the past, and not now in 2.0?

I don't know.

donchambers commented 9 years ago

I'm pretty sure it is safe to remove the language file reference - I did it on one of my development installs without any ill effect.

It seems that reflection and barSinister3 are the only two remaining themes that specify a language file, but do not actually have one. barSinister3 doesn't really need one, because the only thing defined in config.inc.php is a dateformat, so the reference there can be removed.

Reflection is substantially similar to square and rubyx, so I will go ahead and create the english language file for it.

yellowled commented 9 years ago

@garvinhicking I changed the issue to have subissues so we can check progress better. Does blog.s9y.org pull these regularly so that we can check the “problematic” themes again?

@donchambers You already took care of barSinister3, right? Looks like it in the commit log. Thanks.

onli commented 9 years ago

I guess the only actual question here – not necessarily directed at you ;) – is: is there a good reason for having some theme files only in additional_themes/2.0 or can we merge those to additional_themes/master now?

I think we can merge now. If I don't mix things up really bad right now, that branch was never intended by me to survive the 2.0 release.

donchambers commented 9 years ago

You already took care of barSinister3, right? Looks like it in the commit log. Thanks.

Yes.

garvinhicking commented 9 years ago

Yeah it should be fetched every 15 minutes now. Forgot to make the cronjob executable.

On 10.03.2015, at 20:06, Matthias Mees notifications@github.com wrote:

@garvinhicking I changed the issue to have subissues so we can check progress better. Does blog.s9y.org pull these regularly so that we can check the “problematic” themes again?

@donchambers You already took care of barSinister3, right? Looks like it in the commit log. Thanks.

— Reply to this email directly or view it on GitHub.

garvinhicking commented 9 years ago

Who wants to put those 2.0 branch files to master? I can do it tonorrow afternoon if no one else steps in. :)

On 10.03.2015, at 20:19, onli notifications@github.com wrote:

I guess the only actual question here – not necessarily directed at you ;) – is: is there a good reason for having some theme files only in additional_themes/2.0 or can we merge those to additional_themes/master now?

I think we can merge now. If I don't mix things up really bad right now, that branch was never intended by me to survive the 2.0 release.

— Reply to this email directly or view it on GitHub.

yellowled commented 9 years ago

First come, first merge. ;)

I'm pretty sure I'm going to be busy tomorrow. Whoever does the merge should probably also revise the blacklist.txt – I think “the not-sures” should work after the merge.

donchambers commented 9 years ago

✔ Powered ✔ plus9 ✔ plain-vanilla ✔ pixel ✔ pink-lilies ✔ photo ✔ perun_red ✔ perun_blue ✔ party-brown ✔ one_true_layout Newspaper : preview_fullsize.jpg only

That should be all of them now.

yellowled commented 9 years ago

one_true_layout

That's still out there? Jeez.

Thanks again for testing all these. :)

donchambers commented 9 years ago

Thanks again for testing all these. :)

It was painful in many instances. Difficult to believe how ancient some of those themes are. I question whether we should really be making some of the available any longer. Some of them might look a tad better simply by making them wider.

yellowled commented 9 years ago

Honestly, if there was nothing else to consider, I would throw out almost all of them in a heartbeat. But unfortunately, it's not like we're swimming in better alternatives.

I doubt that it's worth the effort to give those old things a makeover, though. :)

yellowled commented 9 years ago

s9y/additional_themes@b7f82ffe5ef22c2c501499fe364b7072cbf50647 should fix blix as well (I screwed up the reference in that commit.)

yellowled commented 9 years ago

And that should fix terrafirma.

yellowled commented 9 years ago

✔ blix ✔ terrafirma

Also removed the former core themes from the blacklist so we can test them now that they have been merged from 2.0.

yellowled commented 9 years ago

✔ mod-modern ✔ mt- ✔ mt3- ✔ newspaper

garvinhicking commented 9 years ago

OK I changed the templatechooser plugin and the spartacus homepage template to view this (should be done with tomorrows update).

@yellowled I added a new [a class="demoURL] in the .template_preview div from templates.inc.tpl - this currently looks nasty, maybe you can properly align it?

yellowled commented 9 years ago

Kind of “first day post-vacation” busy, but I hope I'll find some time to check this later today.

ophian commented 9 years ago

Just to mention it ... Template "next" has a (2cd) search input field right to category sidebar container.

yellowled commented 9 years ago

Will add a fix for that as well.

Also, the s9y blog throws 404s for various lightbox CSS/JS files. Might need a little tweaking in the plugin config?

garvinhicking commented 9 years ago

The reason is that 1024 ie is in templates/additional_themes/1024px/ - that means the http path is not /templates/1024/.

Templates that contain hardcoded paths will thus not run and would need a getfile call instead of hard paths.

So this is nothing that can be changed in any plugin...

On 16.03.2015, at 15:55, Matthias Mees notifications@github.com wrote:

Will add a fix for that as well.

Also, the s9y blog throws 404s for various lightbox CSS/JS files. Might need a little tweaking in the plugin config?

— Reply to this email directly or view it on GitHub.

ophian commented 9 years ago

But the lightbox thing is plugin based, I think. Its not in next for example.

yellowled commented 9 years ago

The issue is that it references a lightbox in /plugins/serendipity_event_lightbox/lightbox/ which (no longer, I assume) exists. There is no reference to these files in any theme in the core or in additional_plugins, so it has to come from the plugin.

yellowled commented 9 years ago

So

yellowled commented 9 years ago

I have one final suggestion, but I don't know if it's possible – should we maybe add the demo link for core themes as well?