Switch from HTTP/Request to HTTP/Request2

[th-h]

HTTP/Request has been discontinued. We should switch to HTTP/Request2 (which has been bundled with s9y, but is not used at all yet, AFAICS).

Those are the plugins that have to be fixed (without retired plugins in /alpha/, and some just use HTTP/Request as a fallback when serendipity_request_url is not present (do we still have to check that?):

• [x] serendipity_event_aggregator
• [x] serendipity_event_amazonchooser
• [x] serendipity_event_commentspice
• [x] serendipity_event_facebook
• [ ] serendipity_event_flickr
• [x] serendipity_event_geotag
• [x] serendipity_event_geourl
• [x] serendipity_event_google_sitemap
• [x] serendipity_event_gravatar
• [x] serendipity_event_podcast
• [x] serendipity_event_recaptcha
• [x] serendipity_event_weblogping
• [x] serendipity_plugin_flickrbadge
• [x] serendipity_plugin_gallery_menalto_random
• [x] serendipity_plugin_ggopis
• [x] serendipity_plugin_imagesidebar
• [x] serendipity_plugin_piwik
• [x] serendipity_plugin_twitter

[garvinhicking]

Actually, serendipity_request_start in s9y version 2.1 and upwards are using HTTP/Request2 in include/functions.inc.php:

function serendipity_request_url($uri, $method = 'GET', $contenttype = null, $data = null, $extra_options = null, $addData = null, $auth = null) {
    global $serendipity;

    require_once S9Y_PEAR_PATH . 'HTTP/Request2.php';

I believe I went through all plugins at that point and added forward compatibility to that layer to use that function, if available?!

[th-h]

AFAIR, some (perhaps: most) plugins check for serendipity_request_url and just fall back to HTTP/Request if that function isn't present, but some just use HTTP/Request.

I'll check again when I finde the time, perhaps sometimes next week, and go through the list.

[garvinhicking]

Ok cool. I think we can leave the fallback in place, when it's there already. If you find plugins where serendipity_request_url is missing we can hopefully add it.

[th-h]

I went through those plugins again - and they have mostly switched to serendipity_request_url. I checked them off in the list above.

Those plugins remain and will need an update:

• serendipity_event_amazonchooser
• serendipity_event_flickr
• serendipity_event_gravatar
• serendipity_plugin_flickrbadge

[th-h]

serendipity_plugin_flickrbadge should be done with s9y/additional_plugins#102, while serendipity_event_flickr is a bit more complex.