sButtons / sbuttons

:bulb: Simple buttons you can use easily for your next project.
https://sbuttons.netlify.app/
MIT License
404 stars 559 forks source link

Fix white neon #1603

Closed Monsieur-Nico closed 2 years ago

Monsieur-Nico commented 2 years ago

Issue: Fix text color for White Neon Border Button in Dark Mode #1600

I just finished working on the issue. The _basic.less: https://github.com/sButtons/sbuttons/blob/dd2652b48903e804a456f4c93761b3a1796fd032/src/components/_basic.less#L148-L151 Became:

&:not(.fill-color-btn):not(.neon-border-btn) {
    color: @darkText !important;
  }
}

And as for the button itself /src/components/styles/_neon-border.less: https://github.com/sButtons/sbuttons/blob/dd2652b48903e804a456f4c93761b3a1796fd032/src/components/styles/_neon-border.less#L68-L76 Became:

&.white-btn {
    .neon(@neonWhite);
    &:hover {
      color: @darkText !important;
    }
    [data-theme="dark"] &,
    &.dark-mode {
      .neon(@neonWhite);
    }
  }

I already merged master into my branch to make sure I am up to date and I will be making a PR

netlify[bot] commented 2 years ago

✔️ You can view the preview now!

🔨 Explore the source changes: 687fcd32140904f0f2797579507466bfea7332bf

🔍 Inspect the deploy log: https://app.netlify.com/sites/sbuttons/deploys/6202c3a93e50590009d70ddb

😎 Browse the preview: https://deploy-preview-1603--sbuttons.netlify.app/

shahednasser commented 2 years ago

Great thanks!

@all-contributors please add @Monsieur-Nico for code and bug

allcontributors[bot] commented 2 years ago

@shahednasser

I've put up a pull request to add @Monsieur-Nico! :tada: