Closed Monsieur-Nico closed 2 years ago
✔️ You can view the preview now!
🔨 Explore the source changes: 687fcd32140904f0f2797579507466bfea7332bf
🔍 Inspect the deploy log: https://app.netlify.com/sites/sbuttons/deploys/6202c3a93e50590009d70ddb
😎 Browse the preview: https://deploy-preview-1603--sbuttons.netlify.app/
Great thanks!
@all-contributors please add @Monsieur-Nico for code and bug
@shahednasser
I've put up a pull request to add @Monsieur-Nico! :tada:
Issue: Fix text color for White Neon Border Button in Dark Mode #1600
I just finished working on the issue. The
_basic.less
: https://github.com/sButtons/sbuttons/blob/dd2652b48903e804a456f4c93761b3a1796fd032/src/components/_basic.less#L148-L151 Became:And as for the button itself
/src/components/styles/_neon-border.less
: https://github.com/sButtons/sbuttons/blob/dd2652b48903e804a456f4c93761b3a1796fd032/src/components/styles/_neon-border.less#L68-L76 Became:I already merged
master
into my branch to make sure I am up to date and I will be making a PR