Support For Federated Login

mathias-ewald commented 1 year ago

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

Problem: I cannot use the integration with my Ambrogio account. Login does not work.

Describe the solution you'd like

Ambrogio allows to login via Google and Apple accounts. While setting up the integration, I am asked to provide credentials (I only assume that, as the form does not give any hints about what's expected in the textfields). I would like to have the option here to login with my Google account.

Describe alternatives you've considered

I could probably delete my Robot and all other devices from my account, create a non-frederated account with Ambrogio and readd everything. But do I want that? Identify federation is a best practice anyway and way more secure due to potential support of MFA.

Additional context

None

sHedC commented 1 year ago

Hi

Thanks for this, so no you don't have to do what you said, I am sorry not had time to work on this at all but want to. ZCS Lawn Mower Robot add-on works better than this right now.

The Ambrogio login is mainly a front to picking up the robot details to log in directly. The ZCS uses things like the IMEI.

I will start working on this again.

ufozone commented 9 months ago

@sHedC, nice work! The login and getting the garage details looks great.

My integration has many features in the entities and services. Your integration has the much better and intuitive setup. I would be happy if we combine our development capacity.

sHedC commented 9 months ago

@sHedC, nice work! The login and getting the garage details looks great.

My integration has many features in the entities and services. Your integration has the much better and intuitive setup. I would be happy if we combine our development capacity.

Hi ufozone should would however if you are talking about the federated login it only works if home assistant is running on localhost, the auth is restricted to only 3 domains one is localhost so always gets rejected once on the server :( Not worked out how to deal with that.

ufozone commented 9 months ago

Argh, of course I briefly tested the latest version in my local dev environment. The source code also looked promising. :-/ I don't find entering the client key so good in my integration. In the iPhone app, for example, it is not easy to read.

We'll have to wait and see anyway: I got the information (from a forum, Facebook group or something) that a completely new app will be released in spring 2024.

sHedC / homeassistant-ambrogio