search

sIKE23 / Mage-Wars

Mage Wars for OCTGN
7 stars 5 forks source link

Automate Domination Scenario Setups #166

Closed sIKE23 closed 9 years ago

sIKE23 commented 9 years ago

I got the set.xml working properly last night, the cards are placing on the Board thought the layout is not correct. I have gone back and made the Markers as Cards the default card size so that should help you with layouts from that perspective. If you want me to do something else with the markers as card size wise its about 15 minutes of work to get it done. Just let me know....

On Wed, Jun 3, 2015 at 7:27 PM, ACG8 notifications@github.com wrote:

Okay, the code I just uploaded should take care of object placement, once one last thing is done.

It appears that the set.xml file in the 8c377c82-86af-45ca-ac7c-75230b803532 set folder is not being recognized by the game. At least, none of the GUIDs defined in that file are recognized by the table.create() function. I don't know how to fix this, but I am guessing that you do. One you have fixed this, try loading a map and let me know whether or not it works.

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/166#issuecomment-108657046.

sIKE23 commented 9 years ago

Did you ever get the chance to get back to this and look at that section (placement) of the code?

On Thu, Jun 4, 2015 at 7:38 PM, Frederick Czajka fczajka@pobox.com wrote:

I got the set.xml working properly last night, the cards are placing on the Board thought the layout is not correct. I have gone back and made the Markers as Cards the default card size so that should help you with layouts from that perspective. If you want me to do something else with the markers as card size wise its about 15 minutes of work to get it done. Just let me know....

On Wed, Jun 3, 2015 at 7:27 PM, ACG8 notifications@github.com wrote:

Okay, the code I just uploaded should take care of object placement, once one last thing is done.

It appears that the set.xml file in the 8c377c82-86af-45ca-ac7c-75230b803532 set folder is not being recognized by the game. At least, none of the GUIDs defined in that file are recognized by the table.create() function. I don't know how to fix this, but I am guessing that you do. One you have fixed this, try loading a map and let me know whether or not it works.

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/166#issuecomment-108657046.

ACG8 commented 9 years ago

Just fixed it. The layouts should work properly now (let me know if they don't).

sIKE23 commented 9 years ago

@ACG8 The RDA area is working and laying out the three cards (Phase, Ini and RDA) properly during setup. However the RDA area moves up and over most of the phase card the first time the dice is rolled on Lost Expeditions map. I will test on the other ones and report back later.

This is a high priority fix....

sIKE23 commented 9 years ago

bad-rda

sIKE23 commented 9 years ago

ongamestart mapDict = eval(getGlobalVariable("Map")) mapDict['DiceBoxLocation'](-640, -25) roll dice mapDict = eval(getGlobalVariable("Map")) mapDict['DiceBoxLocation'](-600, -115)

ACG8 commented 9 years ago

Okay. I'll take a look now and see if I can find the issue.

On Tue, Aug 4, 2015 at 1:24 PM, sIKE23 notifications@github.com wrote:

ongamestart mapDict = eval(getGlobalVariable("Map")) mapDict'DiceBoxLocation' http://-640,%20-25 roll dice mapDict = eval(getGlobalVariable("Map")) mapDict'DiceBoxLocation' http://-600,%20-115

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/166#issuecomment-127700648.

sIKE23 commented 9 years ago

Thanks! If it is a fast one, #259 and #260 I can't figure out.....

On Tue, Aug 4, 2015 at 7:19 PM, Ananda notifications@github.com wrote:

Okay. I'll take a look now and see if I can find the issue.

On Tue, Aug 4, 2015 at 1:24 PM, sIKE23 notifications@github.com wrote:

ongamestart mapDict = eval(getGlobalVariable("Map")) mapDict'DiceBoxLocation' http://-640,%20-25 roll dice mapDict = eval(getGlobalVariable("Map")) mapDict'DiceBoxLocation' http://-600,%20-115

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/166#issuecomment-127700648.

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/166#issuecomment-127802088.

ACG8 commented 9 years ago

Figured it out. The problem was that the moveRDA function is used to move not only the RDA, but also the phase and initiative cards. At the end of the moveRDA function, the position of the object just moved is stored in the map. Problem is, the phase card is moved last, so its position was overwriting the actual RDA position in the map dictionary. In the rollDice function, it deletes the RDA and then creates a new one in the location stored in the map. So when we were rolling the dice, it was deleting the correctly placed RDA and creating a new one in the phase card's location. I fixed it by moving the part of moveRDA that stores the RDA location as a map entry to the conditional block that only evaluates for the actual RDA card.

It is kind of hard to see what I did, though, because I also re-indented a lot of code.

sIKE23 commented 9 years ago

I am very very happy with where we landed on this part of the project!