sIKE23 / Mage-Wars

Mage Wars for OCTGN
7 stars 5 forks source link

Use card special abilities with TAB/Targeting Arrow #176

Open ACG8 opened 9 years ago

ACG8 commented 9 years ago

Many cards have a single special ability that may be used once per round. Example: Hand of Bim-Shalla. With event memory, it should be pretty easy to incorporate these into the action system, using TAB as the activating key. For instance, to use the Hand, one might Select the target, then query the Hand using TAB. Simple, and consistent with the current system for making attacks. Ultimately, all actions and abilities would go through TAB.

Thoughts?

sIKE23 commented 9 years ago

I like it, out of curiosity why did you go with hovering over the source card instead of the targeting arrow?

ACG8 commented 9 years ago

Well, originally I didn't know how to read the arrow's information. Looking again, however, I see that there is an onTargetCardArrow event. Which raises the question: would this be a useful feature?

On the plus side, it is a lot more intuitive than Left Click + TAB. On the minus side, it will reduce players' abilities to indicate what they want to do without triggering a game event. It shouldn't be too hard to add as an option, though. I'll look into it.

Edit: Great point! Just added option to declare attack with targeting arrow. We can expand this to include card special abilities in Q2.

sIKE23 commented 9 years ago

Does triggering a game event slow things down?

On Sun, Mar 1, 2015 at 5:14 AM, ACG8 notifications@github.com wrote:

Well, originally I didn't know how to read the arrow's information. Looking again, however, I see that there is an onTargetCardArrow event. Which raises the question: would this be a useful feature?

On the plus side, it is a lot more intuitive than Left Click + TAB. On the minus side, it will reduce players' abilities to indicate what they want to do without triggering a game event. It shouldn't be too hard to add as an option, though. I'll look into it.

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/176#issuecomment-76592448.

ACG8 commented 9 years ago

Not so much in terms of code speed, though having the menu pop up can slow things down when playing in a game. At the moment, however, indicating a target with the arrow will almost always mean an attack (for cards that have attacks), so I don't think we need to worry about this. Besides, I added an option to turn off arrow-targeting for players that don't like it.