search

sIKE23 / Mage-Wars

Mage Wars for OCTGN
7 stars 5 forks source link

Enhanced enchantment prompt system #284

Open sIKE23 opened 9 years ago

sIKE23 commented 9 years ago

I thought that we had this fixed!

ACG8 commented 9 years ago

Well, we have the Scimitar Buff fixed; note that revealing Bear Strength doesn't actually buff the Scimitar's attack. I agree that the prompt is misleading, though. I'll see about making a temporary patch, and then will find a better way to handle enchantment prompts in the long term.

ACG8 commented 9 years ago

Okay, on reflection, fixing this even just for the scimitar is not trivial, and will require a substantial rewrite to the enchantment prompt system. Currently, the system just looks at which enchantments would be appropriate to reveal at the current battle step, without taking into consideration any of the context. I will have to rewrite it to take more things into account. How critical is this fix?

sIKE23 commented 9 years ago

It is marked as a Q3 fix, if you want to update the topic so it addresses a larger fix then I am fine with that. You wanted to re-write this anyways was my understanding.

//FC

On Mon, Sep 7, 2015 at 11:56 AM, Ananda notifications@github.com wrote:

Okay, on reflection, fixing this even just for the scimitar is not trivial, and will require a substantial rewrite to the enchantment prompt system. Currently, the system just looks at which enchantments would be appropriate to reveal at the current battle step, without taking into consideration any of the context. I will have to rewrite it to take more things into account. How critical is this fix?

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/284#issuecomment-138340232.

ACG8 commented 9 years ago

Yes, that's right. Another thing I want to add is the prompts for enchantments that trigger under conditions other than combat (such as nullify).