search

sIKE23 / Mage-Wars

Mage Wars for OCTGN
7 stars 5 forks source link

Conjurations should not get Slammed/Stunned/Weak type conditions #297

Closed sIKE23 closed 8 years ago

sIKE23 commented 8 years ago

I think this was a part of the code you were going to re-write anyways, but I am not sure.

ACG8 commented 8 years ago

This should already be prevented by line 342, which states:

[if] (e in ['Bleed','Stuck','Stun','Daze','Cripple','Weak','Slam','Stagger'] and defender.Type != 'Creature')): illegalEffect = True

Is this happening in games? If so, under what circumstances?

sIKE23 commented 8 years ago

Surging Wave was placing Slam markers on a Temple of the Dawnbreaker last night in a game I was watching. I looked at the same code and came to the same conclusion, which is why the Issue was given to you. :)

//FC

On Mon, Sep 21, 2015 at 10:00 AM, Ananda notifications@github.com wrote:

This should already be prevented by line 342, which states:

[if](e in ['Bleed','Stuck','Stun','Daze','Cripple','Weak','Slam','Stagger'] and defender.Type !=)): illegalEffect = True

Is this happening in games? If so, under what circumstances?

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/297#issuecomment-142007621.

ACG8 commented 8 years ago

All right, I'll take a look.

ACG8 commented 8 years ago

I am unable to reproduce this issue (I cast surging wave on the ToD and rolled a 9 on the d12, but there was no slam applied). Perhaps we should close this issue? Unless you can tell me how to reproduce this.

sIKE23 commented 8 years ago

Did you try it with 2 players?

On Tue, Dec 15, 2015 at 1:28 PM, Ananda notifications@github.com wrote:

I am unable to reproduce this issue (I cast surging wave on the ToD and rolled a 9 on the d12, but there was no slam applied). Perhaps we should close this issue? Unless you can tell me how to reproduce this.

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/297#issuecomment-164865179.

ACG8 commented 8 years ago

Oh, no. I'll try that.

ACG8 commented 8 years ago

Nope, even with 2 players, I cannot reproduce this bug. I have one mage attack another mage's ToD with Surging Wave and roll an 8, but no slam condition is inflicted.

sIKE23 commented 8 years ago

I can't reproduce now either...I will close.

//FC

On Tue, Dec 15, 2015 at 5:27 PM, Ananda notifications@github.com wrote:

Nope, even with 2 players, I cannot reproduce this bug. I have one mage attack another mage's ToD with Surging Wave and roll an 8, but no slam condition is inflicted.

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/297#issuecomment-164925809.

sIKE23 commented 8 years ago

Closing.....