Update xml files with new cAttacks and tAttacks fields

[ACG8]

Necessary to make the Q3 attack system function. The xml mass editor will help, but much of the work needs to be done manually.

[sIKE23]

What needs to be done?

[ACG8]

Well, mostly the cAttacks fields need to be filled in, which the mass editor can do now. However, there are some cases where it is necessary to go through and make changes ourselves. Namely:

• Attacks that are provided by the spell, but that it does not use itself (e.g. weapons). These need to be moved from cAttacks ("card attacks") to tAttacks ("target attacks")
• Abilities that are listed as action bars but are not actually attacks (e.g. Huginn's ability). These need to be removed from cAttacks entirely.
• Non-standardized traits (e.g. "+2 vs. restrained creatures"). For now, I just want to remove this part of the cAttacks bar (just that part, not the whole attack).

If you want to help with this, that's great; otherwise, I can just do it myself. I am going to start by converting the core set (it would be best if we coordinate to make sure we don't do the same work at the same time).

[sIKE23]

I am open to help. I will be glad to go through and fix these up. What I would recommend first, is to run them all through the parser and then commit them to Git. Then we can split up the work from there. I can do the a smaller one (FiF) to start with and make sure I get right. Let you review and fix anything I missed, I will take the gained knowledge and move to the next small one and so on and so forth.

How do we want to handle the 3 Academy sets?

[ACG8]

They will need to be formatted, just like the arena sets, since academy cards are legal in arena.

I am going to go and run all of the xml files through the parser right now.

[ACG8]

Okay, for non-standardized bonuses I have come up with a notation; basically, we use a notation similar to the cTargets notation to determine the targets against which the bonus applies. For example, to notate

+2 vs nonliving creatures

we can write

bonus=2))tNonliving,TCreature

For OR operators, we can't use || so instead we will use **:

+2 vs nonliving creatures and corporeal conjurations

becomes

bonus=2))tNonliving,TCreature**tCorporeal,TConjuration

However, we will have to enter these manually.

[ACG8]

• Todo: Passage Attack should be listed as an action type, not a trait (I'll fix this).

[ACG8]

It occurs to me that attacks from attack spells should be in the tAttacks of the xml file, not the cAttacks part, since the caster is the source of the attack.

[sIKE23]

I haven't looked very close at the updates you have done over the last couple of weeks, I am not sure what tAttacks are and what cAttacks are. :)

//FC

On Sun, Jan 3, 2016 at 4:11 PM, Ananda notifications@github.com wrote:

It occurs to me that attacks from attack spells should be in the tAttacks of the xml file, not the cAttacks part, since the caster is the source of the attack.

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/316#issuecomment-168544577.

[ACG8]

That was more of a note to myself, but basically cAttacks are attacks that a card itself can declare, and tAttacks are attacks that a card provides to another card, for example attacks on equipment or attack spells. The spell itself does not make these attacks, but another object uses them.