search

sIKE23 / Mage-Wars

Mage Wars for OCTGN
7 stars 5 forks source link

Define Single Zone for Academy #342

Open sIKE23 opened 8 years ago

sIKE23 commented 8 years ago

We need to be able to have one large zone and be able to place the RDA appropriately

ACG8 commented 8 years ago

I don't like the current academy board. For one thing, all the cards will be facing in the same direction (whereas half of the board is upside down); for another, it seems kind of busy. Could we just have a plain square arena?

sIKE23 commented 8 years ago

Yeah I was just playing around a bit. O w going to put it back to just the table top. On Feb 21, 2016 11:13 PM, "Ananda" notifications@github.com wrote:

I don't like the current academy board. For one thing, all the cards will be facing in the same direction; for another, it seems kind of busy. Could we just have a plain square arena?

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/342#issuecomment-187018012.

ACG8 commented 8 years ago

Sounds good. For now, for testing purposes, I'm just going to set it to the 3x3 board; we can find a better image later.

sIKE23 commented 8 years ago

I was just going to copy gameboard.png (the old "no board" image) to gameboard10.png.

sIKE23 commented 8 years ago

Let me know if you like the idea and I will push the changes up to the repo.

//FC

On Sun, Feb 21, 2016 at 11:21 PM, Ananda notifications@github.com wrote:

Sounds good. For now, for testing purposes, I'm just going to set it to the 3x3 board; we can find a better image later.

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/342#issuecomment-187018873.

ACG8 commented 8 years ago

Sure, yes. Let's take a look.

sIKE23 commented 8 years ago

It will be gameboard10 in the gamedef.....those sizes there may need to be tuned...

//FC

On Mon, Feb 22, 2016 at 11:10 AM, Ananda notifications@github.com wrote:

Sure, yes. Let's take a look.

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/342#issuecomment-187272519.

sIKE23 commented 8 years ago

@ACG8 

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "D:\Users\fczajka\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\actions.py", line 651, in onCardArrowTargeted
  File "D:\Users\fczajka\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\attacks.py", line 86, in diceRollMenu
  File "D:\Users\fczajka\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\attacks.py", line 138, in isLegalAttack
  File "D:\Users\fczajka\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\attachcards.py", line 549, in zoneGetDistance
TypeError: 'NoneType' object is not subscriptable

onCardArrowTargeted(EventArgument({"player":Player(2), "fromCard":Card(131085), "toCard":Card(65549), "targeted":True, "scripted":False}```
sIKE23 commented 8 years ago

Would there be a chance that this could effect an Arena game?

"C:\Users\Sharkey\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\attacks.py", line 1344, in computeTraits
  File "<string>", line 1, in <module>
  File "C:\Users\Sharkey\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\actions.py", line 1218, in resolveRegeneration
  File "C:\Users\Sharkey\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\attachcards.py", line 542, in cardGetDistance
  File "C:\Users\Sharkey\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\attachcards.py", line 545, in zoneGetDistance
TypeError: 'NoneType' object is unsubscriptable
resolveRegeneration()
Resolving Rot for sharkbait...
1 damage added to Warlord.
Finished auto-resolving Rot for sharkbait.
Traceback (most recent call last):
  File "C:\Users\Sharkey\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\attacks.py", line 1344, in computeTraits
  File "<string>", line 1, in <module>
  File "C:\Users\Sharkey\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\actions.py", line 986, in resolveDissipate
  File "C:\Users\Sharkey\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\attachcards.py", line 542, in cardGetDistance
  File "C:\Users\Sharkey\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\attachcards.py", line 545, in zoneGetDistance
TypeError: 'NoneType' object is unsubscriptable
resolveDissipate()
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Users\Sharkey\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\actions.py", line 1096, in resolveUpkeep
  File "C:\Users\Sharkey\Documents\Octgn\GameDatabase\9acef3d0-efa8-4d3f-a10c-54812baecdda\scripts\attachcards.py", line 545, in zoneGetDistance
TypeError: 'NoneType' object is unsubscriptable
resolveUpkeep()

I think borders is returning None in the situation....

ACG8 commented 8 years ago

No, I think getZoneContaining is returning None. ZoneGetDistance doesn't work if one of the zones is None. Are you trying to target a card that is not located in a zone? That might be the cause of the problem.

I see that this error is related to upkeep. Does upkeep look at even cards that are outside the zones? That might be the issue.

It might be able to affect an arena game; not sure.

sIKE23 commented 8 years ago

No I was not. But you bring up what is the issue. The placement of the Monolith on one of the board edges leaves the potential to detect cards to the side of the board on the table. In this case the RDA cards. I will setup and test this, but I now believe that to be the issue. I will get back to you and let you know. Thanks for the pointer!

//FC

On Tue, Mar 29, 2016 at 4:11 PM, Ananda notifications@github.com wrote:

No, I think getZoneContaining is returning None. ZoneGetDistance doesn't work if one of the zones is None. Are you trying to target a card that is not located in a zone? That might be the cause of the problem.

I see that this error is related to upkeep. Does upkeep look at even cards that are outside the zones? That might be the issue.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/342#issuecomment-203107510

sIKE23 commented 8 years ago

So if add:

if aZone == None: continue

The loop should just continue with the next card?

Line 1112 in actions.py

On Tue, Mar 29, 2016 at 5:40 PM, Frederick Czajka fczajka@pobox.com wrote:

No I was not. But you bring up what is the issue. The placement of the Monolith on one of the board edges leaves the potential to detect cards to the side of the board on the table. In this case the RDA cards. I will setup and test this, but I now believe that to be the issue. I will get back to you and let you know. Thanks for the pointer!

//FC

On Tue, Mar 29, 2016 at 4:11 PM, Ananda notifications@github.com wrote:

No, I think getZoneContaining is returning None. ZoneGetDistance doesn't work if one of the zones is None. Are you trying to target a card that is not located in a zone? That might be the cause of the problem.

I see that this error is related to upkeep. Does upkeep look at even cards that are outside the zones? That might be the issue.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/342#issuecomment-203107510

ACG8 commented 8 years ago

Yes, that should work, I think.