search

sIKE23 / Mage-Wars

Mage Wars for OCTGN
7 stars 5 forks source link

Bear Strength does not buff attack when revealed during counterstrike step #343

Closed sIKE23 closed 8 years ago

sIKE23 commented 8 years ago

Lightning Raptor attacks Johktari Beastmaster with Electric Bite! sike23 rolls 5 attack dice sike23 rolled 0 normal damage, 2 critical damage, and 3 on the effect die Lightning Raptor inflicts 2 damage on Johktari Beastmaster... (a below average roll) Johktari Beastmaster retaliates with Basic Melee Attack! schwenkgott pays 3 mana. schwenkgott reveals Bear Strength! schwenkgott rolls 3 attack dice schwenkgott rolled 0 normal damage, 4 critical damage, and 4 on the effect die

see? Johktari Beastmaster inflicts 4 damage on Lightning Raptor! (an above average roll) revealed bear str and only 3 dice ---
sIKE23 commented 8 years ago

What would be really cool, looking at this output, is if we noted that the JBM was guarding:

Lightning Raptor attacks the Guarding Johktari Beastmaster with Electric Bite!
ACG8 commented 8 years ago

Should be easy enough to add (re: recognizing guarding). You just have to check whether there is a guard marker.

Was occupied this week, but may have some time this weekend to fix some of these issues.

ACG8 commented 8 years ago

I found the issue. Everything is working perfectly. I am assuming that your Johktari Beastmaster had a stagger when you tested this, right? (from a previous attack from the lightning raptor). When I have the JBM attack the lightning raptor with no stagger condition, she has 5 attack. So I think the problem is that you successfully implemented stagger :)

sIKE23 commented 8 years ago

Was there no issue? On Feb 21, 2016 10:52 PM, "Ananda" notifications@github.com wrote:

I found the issue. Everything is working perfectly. I am assuming that your Johktari Beastmaster had a stagger when you tested this, right? (from a previous attack from the lightning raptor). When I have the JBM attack the lightning raptor with no stagger condition, she has 5 attack. So I think the problem is that you successfully implemented stagger :)

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/343#issuecomment-187010479.

ACG8 commented 8 years ago

Yeah. As far as I can tell, there is no problem.

sIKE23 commented 8 years ago

What about the guarding bit?

ACG8 commented 8 years ago

Haven't worked that in yet, but that is a separate issue. Perhaps we should change the title of this issue to focus on that.

sIKE23 commented 8 years ago

Close this as won't fix, open another one? On Feb 21, 2016 11:24 PM, "Ananda" notifications@github.com wrote:

Haven't worked that in yet, but that is a separate issue. Perhaps we should change the title of this issue to focus on that.

— Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/343#issuecomment-187020219.

ACG8 commented 8 years ago

Sure.