sIKE23 / Mage-Wars

Mage Wars for OCTGN
7 stars 5 forks source link

Rework when Mage Stats are displayed #351

Open sIKE23 opened 8 years ago

sIKE23 commented 8 years ago

Mage Stats should be revealed when the mage card is revealed not when the deck is being validated. The player (in a two player game) loading their deck second can make an educated guess as to what mage they will be facing by letting the other player load their Mage first.

sIKE23 commented 8 years ago

@ACG8

Right now this is what is fed into the chat log on Mage Reveal

sIKE23 prepares a Spell from their Spellbook by placing a card face down on the table.
Anvil Throne Warlord spends Action Marker
Anvil Throne Warlord readies Action Marker
Anvil Throne Warlord readies Quickcast Marker
sIKE23 Channeling is set to 9 and Mana is set to 19 and Life set to 34

I would like to pretty this up a bit.....any thoughts / recommendations?

ACG8 commented 8 years ago

You mean like flavor text? We could add a check to card reveal that checks whether it is a mage, then retrieves a custom message (possibly one of several per mage) based on which mage it is. For instance:

A warlord of the Anvil Throne enters the arena, a look of determination on his face. "Yer ready then?" he grunts.

A warlock of Adramelech appears in a burst of flame. She is laughing maniacally.

A druid enters the arena, flowers blossoming at her feet.

sIKE23 commented 8 years ago

Yeah that would be very cool! You are so good at stuff like that! I also need to figure out if I should suppress the maker comments.

One other thought should we store that "the Mage Reveal event" has happened? The code in question is called from flipcard() and I think we want something like:

if MageRevealEvent == "False" mageSetup()

That way it is only triggered once, the old way was done at ondeckloaded

//FC

On Wed, Apr 27, 2016 at 9:54 AM, Ananda notifications@github.com wrote:

You mean like flavor text? We could add a check to card reveal that checks whether it is a mage, then retrieves a custom message (possibly one of several per mage) based on which mage it is. For instance:

A warlord of the Anvil Throne enters the arena, a look of determination on his face. "Yer ready then?" he grunts.

A warlock of Adramelech appears in a burst of flame. She is laughing maniacally.

A druid enters the arena, flowers blossoming at her feet.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/351#issuecomment-215109642

sIKE23 commented 8 years ago

Your proposal, is it a lot of work? On Apr 27, 2016 10:11 AM, "Frederick Czajka" fczajka@pobox.com wrote:

Yeah that would be very cool! You are so good at stuff like that! I also need to figure out if I should suppress the maker comments.

One other thought should we store that "the Mage Reveal event" has happened? The code in question is called from flipcard() and I think we want something like:

if MageRevealEvent == "False" mageSetup()

That way it is only triggered once, the old way was done at ondeckloaded

//FC

On Wed, Apr 27, 2016 at 9:54 AM, Ananda notifications@github.com wrote:

You mean like flavor text? We could add a check to card reveal that checks whether it is a mage, then retrieves a custom message (possibly one of several per mage) based on which mage it is. For instance:

A warlord of the Anvil Throne enters the arena, a look of determination on his face. "Yer ready then?" he grunts.

A warlock of Adramelech appears in a burst of flame. She is laughing maniacally.

A druid enters the arena, flowers blossoming at her feet.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/sIKE23/Mage-Wars/issues/351#issuecomment-215109642

ACG8 commented 8 years ago

No; I'll handle it, I just have a lot of things on my plate this week. But adding the check should not be very difficult.