sIKE23 / Mage-Wars

Mage Wars for OCTGN
7 stars 5 forks source link

Counterstrikes don't calculate buffs properly #372

Open CarcharodonCarcharias opened 6 years ago

CarcharodonCarcharias commented 6 years ago

The current implementation is something I started tinkering with when trying to figure out how to make counterstrikes work. The original problem was that buffs and debuffs weren't being added to counterstrikes. I thought this was due to the deepcopy setup we have in lines 281-284 of attacks.py. The "if" statement is my doing, but it can easily be removed to go back to the original thing.

Basically, it boils down to the following: If I deepcopy(attack["OriginalAttack"]) no modifiers will be counted. If I skip the deepcopy altogether (like I currently do with the code) then it counts all modifiers x 3 (so melee+1 becomes Melee +3)