sPHENIX-Collaboration / coresoftware

Our big core software repository
https://wiki.bnl.gov/sPHENIX/index.php/Main_Page
27 stars 191 forks source link

PHG4FullProjSpacalCellReco::set_timing_window_defaults #271

Closed haggerty closed 7 years ago

haggerty commented 7 years ago

Looking at a current production file like /sphenix/sim/sim01/production/single_particle/2017-01-13/spacal2d/fieldmap/G4Hits_sPHENIX_e-_eta0_8GeV-0000.root, I see

Error: Can't call PHG4FullProjSpacalCellReco::set_timing_window_defaults(0.0,60.0) in current scope /sphenix/sim/sim01/production/single_particle/2017-01-13/spacal2d/G4_CEmc_Spacal.C:398:

from G4Setup_sPHENIX.C in /sphenix/sim/sim01/production/single_particle/2017-01-13/spacal2d.

I think it's ok when you just modify G4_CEmc_Spacal.C to not call a disapparated method, but that could eventually lead to unforeseen consequences.

sPHENIX-GitHub-l commented 7 years ago

Hi John,

that part of the macro is not called by the production and this production was done before the reco chain code was changed (the cell reco to be precise, at production time this macro ran just fine but it is a snapshot from Jan 13th). This is an attempt to get away from having to store the old macros for reference in favor of some real configuration management (DB based and storage on DST) but since this is a single person effort in a quickly changing environment this is certainly not where is should be. We do keep the macros in git up to date and if there is a backward compatibility breaking change (meaning the old DSTs cannot be processed through the reco chain anymore) we recreate those DSTs.

Chris

On 4/19/2017 9:39 AM, John Haggerty wrote:

Looking at a current production file like /sphenix/sim/sim01/production/single_particle/2017-01-13/spacal2d/fieldmap/G4Hits_sPHENIX_e-_eta0_8GeV-0000.root, I see

Error: Can't call PHG4FullProjSpacalCellReco::set_timing_window_defaults(0.0,60.0) in current scope /sphenix/sim/sim01/production/single_particle/2017-01-13/spacal2d/G4_CEmc_Spacal.C:398:

from G4Setup_sPHENIX.C in /sphenix/sim/sim01/production/single_particle/2017-01-13/spacal2d.

I think it's ok when you just modify G4_CEmc_Spacal.C to not call a disapparated method, but that could eventually lead to unforeseen consequences.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sPHENIX-Collaboration/coresoftware/issues/271, or mute the thread https://github.com/notifications/unsubscribe-auth/AQC2H63bUocGAPc9o7_7LDMhZoucvRZUks5rxg6JgaJpZM4NBsir.


sPHENIX-GitHub-l mailing list sPHENIX-GitHub-l@lists.bnl.gov https://lists.bnl.gov/mailman/listinfo/sphenix-github-l

--


Christopher H. Pinkenburg ; pinkenburg@bnl.gov ; http://www.phenix.bnl.gov/~pinkenbu

Brookhaven National Laboratory ; phone: (631) 344-5692 Physics Department Bldg 510 C ; fax: (631) 344-3253 Upton, NY 11973-5000