MVTX modified geometry (coresoftware)

sPHENIX-Collaboration / coresoftware

Our big core software repository

https://wiki.bnl.gov/sPHENIX/index.php/Main_Page

27 stars 198 forks source link

MVTX modified geometry (coresoftware) #3166

Closed hrjheng closed 3 weeks ago

hrjheng commented 1 month ago

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work for users)
[x] Requiring change in macros repository (Please provide links to the macros pull request in the last section)
[x] I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

Modify MVTX GEANT geometry based on the alignment parameters (i.e "localAlignmentParamFile.txt")
A new PHG4MvtxMisalignment class that calculates the global displacements of MVTX
MakeActsGeometry: fix matching between the ActsSurface and TrkrDef::hitsetkey to account for the global shift of MVTX

Software and simulation meeting on 20241001: https://indico.bnl.gov/event/24940/#14-mvtx-geometry-update

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

macros: https://github.com/sPHENIX-Collaboration/macros/pull/956
calibrations: https://github.com/sPHENIX-Collaboration/calibrations/pull/158

sphenix-jenkins-ci[bot] commented 1 month ago

Build & test report

Report for commit 7f3d09756b635f3f43fab4932a0b8e2e439e4b0c:

builds and tests overall are SUCCESS.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 32.152 / 72, and combined p-Value = 0.999987
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6905 / 72, and combined p-Value = 0.998397
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.0708136 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.4312 / 42, and combined p-Value = 0.294717
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = 19.2441 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = 16.0903 / 20, and combined p-Value = 0.711009
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = 9.22908 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 33.3963 / 56, and combined p-Value = 0.992918
- :bar_chart: QA-tracking : combined Chi2/nDoF = 61.5347 / 56, and combined p-Value = 0.284602
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 80.4504 / 112, and combined p-Value = 0.989301
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = 8.06121 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = 14.2765 / 20, and combined p-Value = 0.816205
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = 12.9983 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 19.6732 / 56, and combined p-Value = 0.999998
- :bar_chart: QA-tracking : combined Chi2/nDoF = 24.1761 / 50, and combined p-Value = 0.999242
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 95.1708 / 112, and combined p-Value = 0.873094
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

_Automatically generated by sPHENIX Jenkins continuous integration_

sphenix-jenkins-ci[bot] commented 1 month ago

Build & test report

Report for commit 2a6f1a2d0bca9c26a4b0afa3cda38413ce7db9b9:

builds and tests overall are SUCCESS.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 32.152 / 72, and combined p-Value = 0.999987
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6905 / 72, and combined p-Value = 0.998397
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.0708136 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.4312 / 42, and combined p-Value = 0.294717
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = 19.2441 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = 16.0903 / 20, and combined p-Value = 0.711009
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = 9.22908 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 34.9525 / 56, and combined p-Value = 0.987694
- :bar_chart: QA-tracking : combined Chi2/nDoF = 61.5347 / 56, and combined p-Value = 0.284602
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 80.4792 / 112, and combined p-Value = 0.989233
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = 8.06121 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = 14.2765 / 20, and combined p-Value = 0.816205
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = 12.9983 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 17.8732 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = 24.1761 / 50, and combined p-Value = 0.999242
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 94.9635 / 112, and combined p-Value = 0.876281
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

_Automatically generated by sPHENIX Jenkins continuous integration_

sphenix-jenkins-ci[bot] commented 1 month ago

Build & test report

Report for commit bbe70dd664145ebf2f26fb3b4d9c5e7987a674b9:

builds and tests overall are SUCCESS.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 32.152 / 72, and combined p-Value = 0.999987
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6905 / 72, and combined p-Value = 0.998397
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.0708136 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.4312 / 42, and combined p-Value = 0.294717
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = 19.2441 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = 16.0903 / 20, and combined p-Value = 0.711009
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = 9.22908 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 34.8264 / 56, and combined p-Value = 0.988209
- :bar_chart: QA-tracking : combined Chi2/nDoF = 61.5347 / 56, and combined p-Value = 0.284602
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 80.4792 / 112, and combined p-Value = 0.989233
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = 8.06121 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = 14.2765 / 20, and combined p-Value = 0.816205
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = 12.9983 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 18.3738 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = 24.1761 / 50, and combined p-Value = 0.999242
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 94.0896 / 112, and combined p-Value = 0.889145
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

_Automatically generated by sPHENIX Jenkins continuous integration_

osbornjd commented 1 month ago

Looking at these clang-tidy issues locally, they are both warnings and not actual errors so I'm not sure why Jenkins flags these as problematic. Regardless, one of them according to stack overflow can be ignored if you really intend to call the function recursively

pinkenburg commented 1 month ago

The recursive is just a warning (it is a possible infinite loop if you call it the wrong way and clang-tidy assumes the worst). If you add this // NOLINTNEXTLINE(misc-no-recursion) right before void PHG4MvtxDetector::SetDisplayProperty(G4LogicalVolume *lv) it suppresses it The other is the use of int active. clang-tidy makes a good point that for bit operations you really should not use ints where the sign bit can mess with you. It looks like active can (should) be an unsigned int. As soon as you change that this error should be gone (depending on what m_IsLayerActive returns, if it's int's there are more problems because bit fiddling using a signed int is error prone as well)

hrjheng commented 1 month ago

m_IsLayerActive returns int as std::array<int, n_Layers> m_IsLayerActive{}; and the std::array is set by m_IsLayerActive[ilayer] = params->get_int_param("active");. I'll just add // NOLINTNEXTLINE(misc-no-recursion) for now

And to add that m_IsLayerActive is not a new object I introduced. It was already in the PHG4MvtxDetector

sphenix-jenkins-ci[bot] commented 1 month ago

Build & test report

Report for commit 0d278efc37326afbfb2484a93404745fd9569b02:

builds and tests overall are SUCCESS.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 32.152 / 72, and combined p-Value = 0.999987
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6752 / 72, and combined p-Value = 0.998407
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.0708136 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.4312 / 42, and combined p-Value = 0.294717
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = 19.2441 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = 16.0903 / 20, and combined p-Value = 0.711009
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = 9.22908 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 34.3794 / 56, and combined p-Value = 0.989895
- :bar_chart: QA-tracking : combined Chi2/nDoF = 61.5347 / 56, and combined p-Value = 0.284602
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 80.4504 / 112, and combined p-Value = 0.989301
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = 8.06121 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = 14.2765 / 20, and combined p-Value = 0.816205
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = 12.9983 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 17.7696 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = 24.1761 / 50, and combined p-Value = 0.999242
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 94.844 / 112, and combined p-Value = 0.878094
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

_Automatically generated by sPHENIX Jenkins continuous integration_

sphenix-jenkins-ci[bot] commented 1 month ago

Build & test report

Report for commit a6a1b02ccc5ab664d6436912621c24052872ebf8:

builds and tests overall are SUCCESS.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 32.152 / 72, and combined p-Value = 0.999987
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6905 / 72, and combined p-Value = 0.998397
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.0708136 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.4312 / 42, and combined p-Value = 0.294717
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = 19.2441 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = 16.0903 / 20, and combined p-Value = 0.711009
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = 9.22908 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 35.1407 / 56, and combined p-Value = 0.986893
- :bar_chart: QA-tracking : combined Chi2/nDoF = 61.5347 / 56, and combined p-Value = 0.284602
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 80.4792 / 112, and combined p-Value = 0.989233
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = 8.06121 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = 14.2765 / 20, and combined p-Value = 0.816205
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = 12.9983 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 18.3359 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = 24.1761 / 50, and combined p-Value = 0.999242
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 95.4017 / 112, and combined p-Value = 0.869484
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

_Automatically generated by sPHENIX Jenkins continuous integration_

sphenix-jenkins-ci[bot] commented 1 month ago

Build & test report

Report for commit c4fbad0a8f67cafc2dc7c4f7e95826693dcfcc3c:

builds and tests overall are SUCCESS.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 32.152 / 72, and combined p-Value = 0.999987
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6905 / 72, and combined p-Value = 0.998397
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.0708136 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.4312 / 42, and combined p-Value = 0.294717
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = 19.2441 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = 16.0903 / 20, and combined p-Value = 0.711009
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = 9.22908 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 34.9561 / 56, and combined p-Value = 0.987679
- :bar_chart: QA-tracking : combined Chi2/nDoF = 61.5347 / 56, and combined p-Value = 0.284602
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 80.4504 / 112, and combined p-Value = 0.989301
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = 8.06121 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = 14.2765 / 20, and combined p-Value = 0.816205
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = 12.9983 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 17.7026 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = 24.1761 / 50, and combined p-Value = 0.999242
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 95.5752 / 112, and combined p-Value = 0.866729
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

_Automatically generated by sPHENIX Jenkins continuous integration_

osbornjd commented 1 month ago

This is the latest build with the macros changes too https://web.sdcc.bnl.gov/jenkins-sphenix/job/sPHENIX/job/test-tracking-low-occupancy-qa/6165/ which show large changes to the QA. We need to understand why this happens as I thought the flags were all set to use the ideal geometry still? So I thought we should get identical performance

hrjheng commented 1 month ago

This is the latest build with the macros changes too https://web.sdcc.bnl.gov/jenkins-sphenix/job/sPHENIX/job/test-tracking-low-occupancy-qa/6165/ which show large changes to the QA. We need to understand why this happens as I thought the flags were all set to use the ideal geometry still? So I thought we should get identical performance

Are you referring to the tpc, tracking, and vertex QAs that show large discrepancies and low KS-test scores?

osbornjd commented 1 month ago

Correct, my understanding was that the flags were turned off which effectively leaves the MVTX in its current unmodified state, meaning we would expect no change in the QA. Is my understanding wrong?

hrjheng commented 1 month ago

It's my understanding too that MVTX should be in the ideal and default position. Curiously INTT and MVTX QA do not change (not sure about TPOT). The only place that might affect tracking is MakeActsGeometry, but I only modified the part relevant to MVTX, void MakeActsGeometry::makeMvtxMapPairs(TrackingVolumePtr &mvtxVolume). I see a few changes to the macro repository that I have not pulled into my branch. I am not sure if it will fix the issue but just want to make sure everything is the same

sphenix-jenkins-ci[bot] commented 4 weeks ago