Micromegas decoding - Githubissues

sPHENIX-Collaboration / coresoftware

Our big core software repository

https://wiki.bnl.gov/sPHENIX/index.php/Main_Page

27 stars 198 forks source link

Micromegas decoding #3222

Closed hupereir closed 2 days ago

hupereir commented 5 days ago

This PR

introduces MicromegasRawHitv2, inspired from TpcRawHitv2.
changes the API to make it more efficient for zero-suppressed data
removes obsolete modules that were duplicating the micromegas decoding in packages/micromegas. Decoding is now done only in one place: SingleMicromegasInput

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work for users)
[ ] Requiring change in macros repository (Please provide links to the macros pull request in the last section)
[x] I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

sphenix-jenkins-ci[bot] commented 5 days ago

Build & test report

Report for commit ea8d802f6945627da1c7aa929b7759d32a173ffc:

builds and tests overall are FAILURE.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 34.4216 / 72, and combined p-Value = 0.999949
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 31.4242 / 72, and combined p-Value = 0.999992
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 3.10515 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 13.6147 / 42, and combined p-Value = 0.99999
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is FAILURE, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

_Automatically generated by sPHENIX Jenkins continuous integration_

sphenix-jenkins-ci[bot] commented 5 days ago

Build & test report

Report for commit 3c95c0f2fe88e1ab9da9839706103211b46791c5:

builds and tests overall are FAILURE.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 34.4216 / 72, and combined p-Value = 0.999949
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 31.4242 / 72, and combined p-Value = 0.999992
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 3.10515 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 13.6147 / 42, and combined p-Value = 0.99999
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is FAILURE, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

_Automatically generated by sPHENIX Jenkins continuous integration_

hupereir commented 4 days ago

I am not sure about the valgrind error. At first look it seems unrelated from this commit, except if the error happens with the new MicromegasRawHit format. (but it is not obvious from the stack trace). Any clue on how to debug this ?

hupereir commented 4 days ago

In the meanwhile I'll fix the clang-tidy errors.

sphenix-jenkins-ci[bot] commented 3 days ago

Build & test report

Report for commit b95a1685d8d655136285db9daf1a2b812e823645:

builds and tests overall are FAILURE.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 34.4216 / 72, and combined p-Value = 0.999949
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 31.4242 / 72, and combined p-Value = 0.999992
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 3.10515 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 13.6147 / 42, and combined p-Value = 0.99999
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is FAILURE, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

_Automatically generated by sPHENIX Jenkins continuous integration_

sphenix-jenkins-ci[bot] commented 3 days ago

Build & test report

Report for commit 0d0cf2a62f6b84c2f76a15fb3f27a377ea3ba354:

builds and tests overall are FAILURE.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 34.4216 / 72, and combined p-Value = 0.999949
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 31.4242 / 72, and combined p-Value = 0.999992
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 3.10515 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 13.6147 / 42, and combined p-Value = 0.99999
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 1.11888e-12 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is FAILURE, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

_Automatically generated by sPHENIX Jenkins continuous integration_

hupereir commented 2 days ago

I missed the fact that when using TClonesArray, changing the containee version also requires changing the container version ... Let's see how this goes.

sphenix-jenkins-ci[bot] commented 2 days ago