accumulated clang-tidy warning fixes - Githubissues

sPHENIX-Collaboration / coresoftware

Our big core software repository

https://wiki.bnl.gov/sPHENIX/index.php/Main_Page

27 stars 198 forks source link

accumulated clang-tidy warning fixes #3229

Closed pinkenburg closed 1 day ago

pinkenburg commented 1 day ago

Types of changes

[ X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work for users)
[ ] Requiring change in macros repository (Please provide links to the macros pull request in the last section)
[x] I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

Just taking care of newly cropped up clang-tidy warnings

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

sphenix-jenkins-ci[bot] commented 1 day ago

Build & test report

Report for commit 37d0de835fdf3de0562d319a55974e05931060cc:

builds and tests overall are SUCCESS.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 34.4216 / 72, and combined p-Value = 0.999949
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 31.4242 / 72, and combined p-Value = 0.999992
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 3.10515 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 13.6147 / 42, and combined p-Value = 0.99999
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = 62.9345 / 72, and combined p-Value = 0.768381
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = 16.3574 / 20, and combined p-Value = 0.694222
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = 920.684 / 54, and combined p-Value = 5.44096e-158
- :bar_chart: QA-Tpc : combined Chi2/nDoF = 75.6719 / 56, and combined p-Value = 0.0410588
- :bar_chart: QA-tracking : combined Chi2/nDoF = 281.267 / 50, and combined p-Value = 5.82986e-34
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 346.107 / 112, and combined p-Value = 1.01039e-25
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

_Automatically generated by sPHENIX Jenkins continuous integration_