search

sPOiDar / fvtt-module-hide-gm-rolls

A FoundryVTT module to hide GM rolls
MIT License
5 stars 11 forks source link

Sanitize GM Rolls no longer working with Ready Set Roll DND5e #41

Open friction1 opened 9 months ago

friction1 commented 9 months ago

Foundry 11.315 DND5e 3.0.2 RSR 3.0.4 HGMR 0.15.3

Screenshot 2024-02-13 at 7 35 55 PM
friction1 commented 9 months ago

This icon for the roll can be turned off in RSR but it would be nice if there was a way to hide it for GM Rolls and not players.

cs96and commented 5 months ago

Also, the "Hide GM Card Item Description" no longer works. I think this is just a dnd5e v3 thing though, nothing to do with Ready Set Roll.

sPOiDar commented 2 months ago

Unfortunately it looks like RSR5e is currently completely broken with recent DND5e versions, so I'm unable to test this. Marking wontfix for now, until someone notifies me that RSR5e is working again (I don't use it).

cs96and commented 2 months ago

Can't you just install dnd5e v3.3 to test with?

sPOiDar commented 2 months ago

I'm not really interested in investing the time - RSR may change again when it's updated to work with current DND5e, and my time budget for these projects is quite limited atm. Support for non-core will also always be best-effort, since it's relevant for fewer users.

I'd be willing to accept a PR from someone who actually uses RSR and can update this module for whatever's changed in RSR.

asherett commented 2 weeks ago

RSR now works fine with dnd5e 4.0.4