sPOiDar / fvtt-module-stream-view

FoundryVTT module that provides a minimal UI view with automated camera work, ideal for streaming or recording games.
MIT License
11 stars 11 forks source link

Monk's Little Details: Combat tracker position settings ignored #34

Open samgrieve opened 2 years ago

samgrieve commented 2 years ago

Editing the values for positioning the combat tracker does not move it. I've tried a variety of values but the combat tracker never moves and is stuck covering my chat log

sPOiDar commented 2 years ago

Changes to positions don't currently update dynamically - they require a refresh of the stream page. Other than that, I can't reproduce the problem here.

ncsululu commented 2 years ago

I am having this exact same issue. I adjusted the positioning and refreshed the page to no effect. image

sPOiDar commented 2 years ago

Are you able to reproduce with no other modules enabled? Also can you tell me what Foundry version and system version you're using?

ncsululu commented 2 years ago

Foundry v10 Build 286 PF2e v4.2.1

It looks like the "Monk's Little Details" module is the culprit on my end. I've disabled it and the issue is fixed.

ChobitsCrazy commented 1 year ago

I had this same issue but they can work together with the correct settings.

  1. you will want to temporarily enable the full sidebar setting for Stream View image

  2. Then you can configure Monk's Little Details on the stream user as such: image

This ensures that Stream View keeps the ability to control the combat pop-out.

arbella commented 1 year ago

Still experincing this bug and the above fix didn't work for me. Ill try some other things in the mean time, or just disable monks combat details.

Cempres commented 1 year ago

@sPOiDar Is it possible to adjust the values to move the combat tracker so it plays "nice" with monks modules, as they're fairly often used by GM's? Currently the module is called "Monk's Combat Details". Thanks in advance and sorry for the @ !

sPOiDar commented 1 year ago

The workaround above works for me. I can't really sensibly stop Monk's code from running, best I might be able to do to automate it is probably to try applying those settings automatically on the Stream user if Monk's Combat Details is active (which is a little brittle, if the settings names ever change), but if those settings don't work reliably as arbella reports then it's out of our control on the Stream View side. I do note that even if Popout Combat Dialog is disabled in Monk's it still messes with the position unless Combat Dialog Position is also set to --.

@Cempres did you try the above workaround from ChobitsCrazy? If so, did it work reliably for you?

arbella commented 1 year ago

The workaround above works for me. I can't really sensibly stop Monk's code from running, best I might be able to do to automate it is probably to try applying those settings automatically on the Stream user if Monk's Combat Details is active (which is a little brittle, if the settings names ever change), but if those settings don't work reliably as arbella reports then it's out of our control on the Stream View side. I do note that even if Popout Combat Dialog is disabled in Monk's it still messes with the position unless Combat Dialog Position is also set to --.

@Cempres did you try the above workaround from ChobitsCrazy? If so, did it work reliably for you?

Hey! I completely removed monks combat details, and now the combat tracker works fine! Thought i should keep you updated.