search

sPOiDar / fvtt-module-stream-view

FoundryVTT module that provides a minimal UI view with automated camera work, ideal for streaming or recording games.
MIT License
11 stars 11 forks source link

feat(camera): Allow ignoring invisible player tokens #44

Closed magroader closed 1 year ago

magroader commented 1 year ago

Closes #38

cs96and commented 1 year ago

I think there should be a setting to enable/disable this.

magroader commented 1 year ago

Setting added to PR

sPOiDar commented 1 year ago

Sorry for the delay in reviewing this, have had little time for personal projects the last year.

Can you flip the logic and text of the setting so that it's Ignore Invisible Players, that defaults to off, so that it becomes opt-in, and we don't change behaviour for existing users?

Also, please squash to a single commit and update the commit message to read:

feat(camera): Allow ignoring invisible player tokens

so that it's picked up by my CI correctly.

Thanks!