search

sPavl0v / react-spa-prenderer

MIT License
34 stars 17 forks source link

Added outputDirectory option #15

Closed icellan closed 1 year ago

icellan commented 2 years ago

Hi,

I added an outputDirectory option to be able to render the pages into a separate directory.

This can be useful when serving the content in a dynamic way. In my case, I am serving my site from Go, with most files embedded in the executable for fast access, but I do not want all the static HTML files in the build, but in a separate directory.

This is described in my medium post at https://medium.com/@siggi.oskarsson/running-react-in-a-go-api-server-1ad8d40c2411

Hope it is useful.

sPavl0v commented 1 year ago

Hi, buildDirectory property supposed to cover this kind of functionality. For now i can't see any reasons to add this functionality. But still thanks for your contribution!

icellan commented 1 year ago

Hi @sPavl0v The PR was created to allow differentiating between where the output of Puppeteer is put. In my case I needed it to be in a different directory than the rest of the build.