sQUlearn / squlearn

scikit-learn interface for quantum algorithms
https://squlearn.github.io
Apache License 2.0
58 stars 18 forks source link

Rename Feature maps -> Encoding Circuits #132

Closed rothma closed 1 year ago

rothma commented 1 year ago

Because it's the right thing to do

rothma commented 1 year ago

Proposals:

rothma commented 1 year ago

Final discussion with @David-Kreplin and then go to work

rothma commented 1 year ago

@David-Kreplin brought up a potential issue with non-x-dependent circuits --> pqc?

Also, let's change the name of the implemented feature maps to something meaningful (e.g. qek, param_z, highdim?)

JanSchnabel commented 1 year ago

But the same would hold for only-x-depending circuits. Okay, then x can be viewed as parameter and therefore pqc would be fine. What about something even more general like SqulearnCircuits as analogue to Qiskit's QuantumCircuit?

MoritzWillmann commented 1 year ago

@David-Kreplin brought up a potential issue with non-x-dependent circuits --> pqc?

Does this UC exist? I'd be fine with pqc aswell, though.

But the same would hold for only-x-depending circuits. Okay, then x can be viewed as parameter and therefore pqc would be fine. What about something even more general like SqulearnCircuits as analogue to Qiskit's QuantumCircuit?

I'm not sure if we should come up with something that isn't really meaningful. Just calling it Circuit or QuantumCircuit might work though.

JanSchnabel commented 1 year ago

There is also the proposal "Ansatz" in one of the comments above -> AnsatzCircuit would be another suggestion to be more different from Qiskit

rothma commented 1 year ago

Since data encoding circuits will be the default case, I would prefer to keep it as a name. My suggestion would be to rename the feature_maps_implemented to data encoding circuits and maybe rename the parent folder to circuits or something along these lines.

David-Kreplin commented 1 year ago

Closed with PR #159