Clean `__init__` and `set_params` - Githubissues

sQUlearn / squlearn

scikit-learn interface for quantum algorithms

https://squlearn.github.io

Apache License 2.0

57 stars 18 forks source link

Clean `init` and `set_params` #161

Closed MoritzWillmann closed 1 year ago

MoritzWillmann commented 1 year ago

This PR

utilizes bit-wise comparison between kwargs and self.get_params() in __init__ to decide which arguments should be forwarded to set_params
utilizes bit-wise comparison between params and according params in set_params to decide which arguments get assinged to which attribute
closes issue #108

All in all this unifies the code and in my opinion makes it cleaner and more readable. Open to discuss.