sQUlearn / squlearn

scikit-learn interface for quantum algorithms
https://squlearn.github.io
Apache License 2.0
53 stars 18 forks source link

fix for issue #271 #272

Open David-Kreplin opened 4 weeks ago

David-Kreplin commented 4 weeks ago

fix for issue #271

David-Kreplin commented 3 weeks ago

There is an issue with the dxdx derivative and the arcos function, that has to be fixed before merging.

David-Kreplin commented 3 weeks ago

The final fix for #271 depends on an PennyLane issue: https://github.com/PennyLaneAI/pennylane/issues/5824 I would suggest to merge this PR, since at least mixed deritives are working with this fix.

MoritzWillmann commented 4 days ago

Will we need to change things back when things are fixed in Pennylane?

David-Kreplin commented 4 days ago

I think, no further adjustments are necessary. But we have to wait until the PennyLane issue is fixed to be sure.