sQu1rr / nerd-treeview

Vim-like NERD Tree behaviour for Atom.io Tree View
https://atom.io/packages/nerd-treeview
MIT License
19 stars 5 forks source link

Saving folder expansion state not working #10

Closed dcalhoun closed 8 years ago

dcalhoun commented 8 years ago

Unless I'm misunderstanding the meaning of "saving folder expansion state" from the README, this ability appears to be broken. Specifically, I've seen it fail with the nerd-treeview:change-root command.

Behavior

With the following structure:

└── directory-a
    └── directory-b
        ├── directory-c
        ├── directory-d
        │   └── directory-f
        │       ├── directory-g
        │       │   └── index.js
        │       └── directory-h
        │           └── index.js
        └── directory-e
  1. Open tree view: CMD - \
  2. Open directory-a, directory-b, directory-d, directory-f, directory-g, and directory-h: o
  3. Change the root directory to directory-b: C

    Current Outcome

The tree view root folder changes to highlighted directory-b, children directories lose their state and collapse.

Expected Outcome

The tree view root folder changes to highlighted directory-b, children directories retain their state and remain open (i.e. — directory-b, directory-d, directory-f, directory-g, and directory-h remain open).

Environment

sQu1rr commented 8 years ago

confirmed, U works as expected though which is interesting

sQu1rr commented 8 years ago

Need some testing before i'll release a patched version. Seem to work for me

dcalhoun commented 8 years ago

:+1: Yep, works for me as well.