Open file always creates new tab

sQu1rr / nerd-treeview

Vim-like NERD Tree behaviour for Atom.io Tree View

https://atom.io/packages/nerd-treeview

MIT License

19 stars 5 forks source link

Open file always creates new tab #19

Closed dcalhoun closed 7 years ago

dcalhoun commented 7 years ago

Steps to Reproduce

Open a file in the editor.
Focus on nerd-treeview via C-0.
Move highlight to a different file from the one currently open in the editor.
Open a different file via o (nerd-treeview:open).

Expected Result

File replaces currently open file.

Current Result

File opens in a new tab, as if the user pressed t (nerd-treeview:open-tab).

Environment

nerd-treeview 0.5.3
Atom 1.17.0
macOS 10.12.4

sQu1rr commented 7 years ago

Will take a look/test next week. Thanks for the report.

sQu1rr commented 7 years ago

@dcalhoun - I tested on my atom 1.16 and it seems to work as expected. Does o always result in opening a file in a new tab for you? Did it start recently? Do you have native tree-view keybindings disabled?

dcalhoun commented 7 years ago

Thank you for looking into it.

Yes, o always results in a new tab.
Yes, it started recently—probably within the last month.
Yes, I have tree-view keybindings disabled in my atom/config.cson:
```
packagesWithKeymapsDisabled: [
"tree-view"
]
```

I have also disabled all other thirty-party plugins and continue to experience the issue.

You likely need to upgrade to Atom 1.17.0 to experience the issue. One notable change is...

Removal of jQuery from all bundled packages

sQu1rr commented 7 years ago

I can confirm this issue on 1.17.0, will look into it