search

sVerentsov / Circuit-Checker-Factorio

Mod for Factorio that helps in troubleshooting your circuit networks.
MIT License
0 stars 0 forks source link

false positve error #2

Closed Xaver222 closed 1 year ago

Xaver222 commented 1 year ago

There is one bug, it will display as error even trough the game can use combinators in this way. 2023-05-07 20_25_16-Window 2023-05-07 20_24_52-Window 2023-05-07 20_24_26-Window

Input any, and output a signal, as input counter, will work even there is no input signal of this kind present

Xaver222 commented 1 year ago

another one, if one input is set to a constant number: 2023-05-07 20_50_48-Window

sVerentsov commented 1 year ago

Will check, thank you for the report!

sVerentsov commented 1 year ago

@Xaver222 Updated in 1.1.4, could you please check if I understood your cases correctly?

Xaver222 commented 1 year ago

@sVerentsov Thnx for the fast response! Yeah both fixed. Just minior thing in the change log you point out: "Fixed false positive when first argument to arithmetic combinator is a constant" in game someone can put constat number in any of the two input slots, I just checked and your fix work even if first input is signal and second input is constant. So everything is fine. Thnx again

sVerentsov commented 1 year ago

Constant second argument worked before, so I didn't mention it in the changelog